New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit .valueOf() calls instead of coercion #2877

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
4 participants
@topaxi
Contributor

topaxi commented Jan 8, 2016

This seems to result in speedups by around 10% for comparing moments.

http://jsperf.com/explicit-valueof-for-momentjs

@mj1856 mj1856 added the performance label Jan 16, 2016

@mj1856

This comment has been minimized.

Member

mj1856 commented Jan 16, 2016

Doesn't seem like it would hurt. It's only a few extra characters. @ichernev, thoughts?

@maggiepint maggiepint added this to the 2.13.0 milestone Apr 10, 2016

@ichernev

This comment has been minimized.

Contributor

ichernev commented Apr 11, 2016

Sure, 10% faster is good. Thank you @topaxi

@ichernev

This comment has been minimized.

Contributor

ichernev commented Apr 16, 2016

Merged in 2749f08

@ichernev ichernev closed this Apr 16, 2016

ichernev added a commit that referenced this pull request Apr 16, 2016

Merge pull request #2877 from topaxi:explict-valueof
Use explicit .valueOf() calls instead of coercion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment