New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse string arguments for month() correctly, closes #2884 #2897

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
3 participants
@andrewkolesnikov

andrewkolesnikov commented Jan 15, 2016

Lets moment().month('7') work the same as moment().month(7)

@mj1856

This comment has been minimized.

Member

mj1856 commented Jan 16, 2016

Thanks for your contribution! Staging for next release.

@mj1856 mj1856 added this to the 2.12.0 milestone Jan 16, 2016

@ichernev

This comment has been minimized.

Contributor

ichernev commented Mar 6, 2016

Merged in 602718d

@ichernev ichernev closed this Mar 6, 2016

ichernev added a commit that referenced this pull request Mar 6, 2016

Merge pull request #2897 from andrewkolesnikov:develop
parse string arguments for month() correctly, closes #2884
@ichernev

This comment has been minimized.

Contributor

ichernev commented Mar 6, 2016

I converted the string to int before using it in the daysInMonth computation : 96b771b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment