deps: peg grunt to ~0.4 #3092
Merged
deps: peg grunt to ~0.4 #3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev deps cannot pass with grunt > 0.4 1.0 will fail without deps themselves updating. PEgging the grunt dep ensures that npm install will work without error fixes moment#3091
|
ping @ichernev |
|
@thealphanerd thanks, looks good. |
|
@thealphanerd do you also need a new release tag, or just develop branch is fine. |
|
a release would be preferable. This breaks us being able to test in ci |
|
@ichernev quick ping about a release tag. Just had a team reach out about this module failing their smoke tests |
|
I'll try to release this weekend. |
|
@thealphanerd 2.13.0 is released in npm, hope its all good on your end now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev deps cannot pass with grunt > 0.4
1.0 will fail without deps themselves updating. PEgging the grunt dep
ensures that npm install will work without error
fixes #3091