New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localeSorted argument to weekday listers #3105

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
4 participants
@ichernev
Contributor

ichernev commented Apr 12, 2016

Fixes #2927, redo #3103

@Changron

This comment has been minimized.

Changron commented Apr 12, 2016

what is the last parameter "setter" of function get for, btw?
I don't really get it when I implemented it.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Apr 14, 2016

@Changron its used to set the given unit to the given value, so you have a moment whoose unit is value (weekday is 5), so you can get the name of it in the locale ...

@ichernev ichernev added this to the 2.13.0 milestone Apr 14, 2016

@ichernev

This comment has been minimized.

Contributor

ichernev commented Apr 16, 2016

Merged in 1a460a9

@ichernev ichernev closed this Apr 16, 2016

ichernev added a commit that referenced this pull request Apr 16, 2016

Merge pull request #3105 from ichernev:add-locale-sorted-weekdays
Add localeSorted argument to weekday listers
@desfero

This comment has been minimized.

desfero commented May 30, 2017

@ichernev do we have such option to moment local locale?

Something like this below does not work.

moment().locale('pl').localeData().weekdays(true) 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment