New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1756 Resolved thread-safe issue on server side. #3109

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
3 participants
@wadahiro
Contributor

wadahiro commented Apr 13, 2016

As mentioned in #1756, there is a thread-safe issue when we use Moment on the server side of the multi-threaded model (e.g. Rhino).

I noticed the scope of variable i in makeFormatFunction function is too wide. The variable is shared in multiple threads. It causes unpredictable behavior.

@wadahiro wadahiro referenced this pull request Apr 13, 2016

Closed

Moment unparsable date #1756

@ichernev ichernev added this to the 2.13.0 milestone Apr 14, 2016

@ichernev

This comment has been minimized.

Contributor

ichernev commented Apr 14, 2016

Thanks, we'll merge that.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Apr 16, 2016

Merged in 6558bdb

@ichernev ichernev closed this Apr 16, 2016

ichernev added a commit that referenced this pull request Apr 16, 2016

Merge pull request #3109 from wadahiro:threadsafe_on_server_side
Fix #1756 Resolved thread-safe issue on server side.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment