Add support for month/weekday callbacks in moment.fn.format #313

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@timrwood
Member
@timrwood
Member

For reference, here is the file size increase.

+59 min
+20 gzip

@rockymeza
Contributor

I don't think that we can accept this pull request if it doesn't have any tests for the second code branch. There are currently no languages that have these callbacks, so we could either write tests that add a callback and run it, or we could wait until the Russian changes are made.

@timrwood timrwood was assigned Jun 11, 2012
@timrwood
Member

This PR is useless with the new formatter, but I did add the functionality in with another commit.

I added unit tests as well with a dummy language, so at least we have coverage.

Another language had reason to use these callbacks, so I though it would be good to merge in so TR and RU can write code against it.

@timrwood timrwood closed this Jun 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment