New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix #2704 - isoWeekday(String) inconsistent with isoWeekday(Number) #3177

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
3 participants
@nvdh
Contributor

nvdh commented May 11, 2016

Bug fix for issue #2704 as requested by @mj1856

@nvdh nvdh referenced this pull request May 11, 2016

Merged

Documentation bug fix #2704 #301

@nvdh nvdh changed the title from Fixes #2704 - isoWeekday(String) inconsistent with isoWeekday(Number) to Bug Fix #2704 - isoWeekday(String) inconsistent with isoWeekday(Number) May 11, 2016

@@ -82,6 +82,19 @@ function parseWeekday(input, locale) {
return null;
}
function parseIsoWeekday(input, locale) {

This comment has been minimized.

@ichernev

ichernev Jun 7, 2016

Contributor

I think falling back to parseWeekday is a bit excessive. If its string go through localeParse. If we now have number do the modulus. Return null if any of those fail.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Jun 7, 2016

@nvdh thank you for workung on this. Looks good just address the small comment and it will be merged.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Jun 14, 2016

Merged in 07358ff

@ichernev ichernev closed this Jun 14, 2016

ichernev added a commit that referenced this pull request Jun 14, 2016

Merge pull request #3177 from nvdh:bugfix-2704
Bug Fix #2704 - isoWeekday(String) inconsistent with isoWeekday(Number)

@mj1856 mj1856 added this to the 2.14.0 milestone Jul 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment