New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative 0 in certain diff cases #3232

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
3 participants
@ichernev
Contributor

ichernev commented Jun 12, 2016

Fixes #3227

@maggiepint

This comment has been minimized.

Member

maggiepint commented Jun 12, 2016

LGTM. Glad I could write all that test scaffolding for you :-)

@ichernev

This comment has been minimized.

Contributor

ichernev commented Jun 12, 2016

@maggiepint not only that, but the || 0 hack from tim ;-)

@maggiepint

This comment has been minimized.

Member

maggiepint commented Jun 12, 2016

I felt so stupid when he pointed that out 😃. One of those moments where you wonder if you're in the right profession.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Jun 14, 2016

@maggiepint heh, nobody is stupid because they didn't think of a hack. This is not a google interview ...

@ichernev

This comment has been minimized.

Contributor

ichernev commented Jun 14, 2016

Merged in f01ca7a

@ichernev ichernev closed this Jun 14, 2016

ichernev added a commit that referenced this pull request Jun 14, 2016

Merge pull request #3232 from ichernev:neg-0-diff
Fix negative 0 in certain diff cases

@mj1856 mj1856 added this to the 2.14.0 milestone Jul 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment