New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce month.isFormat for format/standalone discovery #3233

Closed
wants to merge 2 commits into
base: develop
from

Conversation

Projects
None yet
3 participants
@ichernev
Contributor

ichernev commented Jun 12, 2016

Fixes #3195
@mmozuras can you please verify the tests are now OK. They should be more accurate after this change, but I'm not a native speaker (nor any other kind :)).

@@ -22,7 +22,7 @@ test('parse', function (assert) {
test('format', function (assert) {
var a = [
['dddd, Do MMMM YYYY, h:mm:ss a', 'sekmadienis, 14-oji vasario 2010, 3:25:50 pm'],
['dddd, Do MMMM YYYY, h:mm:ss a', 'sekmadienis, 14-oji vasaris 2010, 3:25:50 pm'],

This comment has been minimized.

@mmozuras

mmozuras Jun 14, 2016

Contributor

This should stay vasario.

@mmozuras

This comment has been minimized.

Contributor

mmozuras commented Jun 14, 2016

@ichernev other than my single comment, everything else looks 🆗.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Jun 15, 2016

Merged in 3ec23a5

@ichernev ichernev closed this Jun 15, 2016

ichernev added a commit that referenced this pull request Jun 15, 2016

Merge pull request #3233 from ichernev:mont-is-format-lt
Introduce month.isFormat for format/standalone discovery

@mj1856 mj1856 added this to the 2.14.0 milestone Jul 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment