New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new locale] ar-ly: Arabic (Lybia) locale #3267

Closed
wants to merge 5 commits into
base: develop
from

Conversation

Projects
None yet
4 participants
@kikoanis
Contributor

kikoanis commented Jun 26, 2016

No description provided.

@kikoanis kikoanis changed the title from Adding Arabic-Libya locale to Adding Arabic-Libya locale (ar-ly) Jun 26, 2016

@kifcaliph

This comment has been minimized.

kifcaliph commented Jul 27, 2016

you need to change the dow to be 1 to match the real day. in file src/locale/ar-ly.js

@@ -6,6 +6,7 @@
"files": [
"moment.js",
"locale/af.js",
"locale/ar-ly.js",

This comment has been minimized.

@ichernev

ichernev Aug 12, 2016

Contributor

You don't need to change this file -- its autogenerated.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Aug 12, 2016

@kikoanis @kifcaliph which is the first day of the week in Libya?

@ichernev ichernev added this to the 2.15.0 milestone Aug 12, 2016

@mj1856 mj1856 added the Language label Aug 12, 2016

@kifcaliph

This comment has been minimized.

kifcaliph commented Aug 19, 2016

it is supposed to be Sunday

@mj1856

This comment has been minimized.

Member

mj1856 commented Aug 27, 2016

Please undo the change to component.json and rebase to a single commit. Thanks!

@mj1856 mj1856 added Needs Revision and removed todo labels Aug 27, 2016

@kikoanis

This comment has been minimized.

Contributor

kikoanis commented Aug 28, 2016

Done... Sorry about the delay

@kikoanis

This comment has been minimized.

Contributor

kikoanis commented Aug 28, 2016

First day of the week in Libya is Saturday.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Sep 1, 2016

Merged in 6cf3f1f

@ichernev ichernev closed this Sep 1, 2016

ichernev added a commit that referenced this pull request Sep 1, 2016

Merge pull request #3267 from kikoanis:develop
[new locale] ar-ly: Arabic (Libya) locale

@ichernev ichernev changed the title from Adding Arabic-Libya locale (ar-ly) to [new locale] ar-ly: Arabic (Lybia) locale Sep 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment