New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg] jspm: Include moment.d.ts file in package #3273

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
4 participants
@tamird
Contributor

tamird commented Jul 2, 2016

Similar to aea2a89 and required for
use with https://github.com/frankwallis/plugin-typescript.

@tamird

This comment has been minimized.

Contributor

tamird commented Jul 9, 2016

@ichernev ping

tamird added a commit to tamird/cockroach that referenced this pull request Jul 9, 2016

ui: update typings
lodash is moved out of global dependencies.

A JSPM override is added to use moment's bundled typings due to
moment/moment#3273.

@tamird tamird referenced this pull request Jul 9, 2016

Merged

ui: update typings #7717

@ichernev

This comment has been minimized.

Contributor

ichernev commented Jul 10, 2016

This will go out in next release.

@tamird

This comment has been minimized.

Contributor

tamird commented Jul 11, 2016

Did you mean to merge it?

@maggiepint

This comment has been minimized.

Member

maggiepint commented Jul 21, 2016

Iskren merges at release time. I've given this a release tag.

@mj1856 mj1856 modified the milestone: 2.15.0 Aug 5, 2016

@mj1856 mj1856 added the TypeScript label Aug 12, 2016

@ichernev

This comment has been minimized.

Contributor

ichernev commented Sep 4, 2016

Merged in b9a59ea

@ichernev ichernev changed the title from Include moment.d.ts file in packages (jspm) to [pkg] jspm: Include moment.d.ts file in package Sep 4, 2016

@ichernev ichernev closed this Sep 4, 2016

ichernev added a commit that referenced this pull request Sep 4, 2016

Merge pull request #3273 from tamird:patch-1
[pkg] jspm: Include moment.d.ts file in package

@tamird tamird deleted the tamird:patch-1 branch Sep 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment