New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new locale] zh-hk: Chinese (Hong Kong) locale #3333

Closed
wants to merge 2 commits into
base: develop
from

Conversation

Projects
None yet
3 participants
@skfd
Contributor

skfd commented Jul 28, 2016

Adds zh-hk support by copying zh-tw definition and tests.

I'm aware of parentLocale option. But combination of parentLocale option and localeModule test helper is buggy for me. Will try to report the issue in separate pull request as a test case.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Aug 12, 2016

@skfd for now we're not using parentLocale for the builtin locales. There are talks about actually doing it which might save some space for people including all locales.

This will be released in next version, thank you!

@ichernev ichernev added this to the 2.15.0 milestone Aug 12, 2016

@mj1856 mj1856 added the Language label Aug 12, 2016

@ichernev

This comment has been minimized.

Contributor

ichernev commented Sep 3, 2016

Merged in d48c073

@ichernev ichernev changed the title from Adds `zh-hk` support. to [new locale] zh-hk: Chinese (Hong Kong) locale Sep 3, 2016

@ichernev ichernev closed this Sep 3, 2016

ichernev added a commit that referenced this pull request Sep 3, 2016

Merge pull request #3333 from skfd:feature-loc-zh-hk
[new locale] zh-hk: Chinese (Hong Kong) locale
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment