New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new locale] tet: Tetun Dili (East Timor) locale #3342

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
3 participants
@joshbrooks
Contributor

joshbrooks commented Aug 2, 2016

Credit to @marobo for initial release

@joshbrooks joshbrooks closed this Aug 2, 2016

@joshbrooks joshbrooks reopened this Aug 2, 2016

@@ -0,0 +1,66 @@
//! moment.js locale configuration
//! locale : Tetun Dili (East Timor) [tdt]

This comment has been minimized.

@ichernev

ichernev Aug 12, 2016

Contributor

you need to add an author line here (check the other locales for example). A good place to credit @marobo or anybody else who helped.

@mj1856

This comment has been minimized.

Member

mj1856 commented Aug 12, 2016

A couple of points:

  1. The ISO 639-2 code for the Tetum language is tet, not tdt.
  2. You are creating the file in the /locale, folder, which is the output folder for the build process. Please create the file in /src/locale, and a corresponding unit test in /src/test/locale. Refer to the contributing guidelines.
@joshbrooks

This comment has been minimized.

Contributor

joshbrooks commented Aug 15, 2016

We use 'tdt' for some of our internal work ('Tetum dili') but tet is a better option as it's a recognised -2 code (tdt being a -3). Filenames have been changed to suit.
Files have been moved to source folder as requested, and tests are all passing. Thanks for the help @mj1856

@ichernev

This comment has been minimized.

Contributor

ichernev commented Nov 1, 2016

@joshbrooks thank you. This will go out in next release.
I just need you to sign the CLA.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Nov 5, 2016

@joshbrooks can you please sign the CLA. I can not proceed otherwise.

@joshbrooks

This comment has been minimized.

Contributor

joshbrooks commented Nov 7, 2016

@ichernev CLA has been signed, Apologies for the delay and thank you.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Nov 7, 2016

Merged in 270d7f2

@ichernev ichernev changed the title from Add locale settings for Tetum to [new locale] tet: Tetun Dili (East Timor) locale Nov 7, 2016

@ichernev ichernev closed this Nov 7, 2016

ichernev added a commit that referenced this pull request Nov 7, 2016

Merge pull request #3342 from catalpainternational:develop
[new locale] tet: Tetun Dili (East Timor) locale

@mj1856 mj1856 added this to the 2.16.0 milestone Nov 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment