New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new locale] yo: Yoruba (Nigeria) locale #3435

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
5 participants
@realbisoye
Contributor

realbisoye commented Sep 14, 2016

No description provided.

@realbisoye

This comment has been minimized.

Contributor

realbisoye commented Sep 14, 2016

@mj1856 Changes rebased into one single commit, thanks.

@mj1856

This comment has been minimized.

Member

mj1856 commented Sep 14, 2016

Thanks. For future reference, you could have just rebased the existing branch and pushed, and it would have updated the original PR (#3424) instead of closing and creating a new one. But this is fine.

@mj1856 mj1856 added the Language label Sep 14, 2016

@mj1856 mj1856 added this to the 2.16.0 milestone Sep 14, 2016

@realbisoye

This comment has been minimized.

Contributor

realbisoye commented Sep 14, 2016

Oh, noted. Thanks.

@maggiepint

This comment has been minimized.

Member

maggiepint commented Nov 1, 2016

Heads up. Because we came under JS Foundation management, we need a CLA signed for this to be merged. Should be just a couple clicks.

@realbisoye

This comment has been minimized.

Contributor

realbisoye commented Nov 1, 2016

@maggiepint, CLA agreement signed. I noticed there have been no updates on the checks though.

@ichernev ichernev added the cla-problem label Nov 5, 2016

@JSFOwner

This comment has been minimized.

Member

JSFOwner commented Nov 5, 2016

The author information in the commit is invalid. The commit must contain your username and email to pass the CLA signature check. Please update the commit with correct author information.

@realbisoye

This comment has been minimized.

Contributor

realbisoye commented Nov 8, 2016

@ichernev commit updated with author information.

@mj1856 mj1856 modified the milestones: 2.17.0, 2.16.0 Nov 10, 2016

@mj1856 mj1856 removed the cla-problem label Nov 10, 2016

ichernev added a commit that referenced this pull request Nov 12, 2016

Merge pull request #3435 from andela-batolagbe:add-yoruba-locale
[new locale] yo: Yoruba (Nigeria) locale
@ichernev

This comment has been minimized.

Contributor

ichernev commented Nov 12, 2016

Merged in fae8004

@ichernev ichernev changed the title from add locale for Yoruba, Nigeria to [new locale] yo: Yoruba (Nigeria) locale Nov 12, 2016

@ichernev ichernev closed this Nov 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment