New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Fix #2300: Default to current week. #3515

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
6 participants
@markstos
Contributor

markstos commented Oct 20, 2016

This is an alternative to Pull Request #3406 which adds one improvement:

It updates Brian Schemp's patch calculates the current week once
instead of twice for a small performance boost.

Fix #2300: Default to current week.
This update to Brian Schemp's patch calculates the current week once
instead of twice for a small performance boost.
@maggiepint

This comment has been minimized.

Member

maggiepint commented Nov 1, 2016

Heads up. Because we came under JS Foundation management, we need a CLA signed for this to be merged. Should be just a couple clicks.

@markstos

This comment has been minimized.

Contributor

markstos commented Nov 1, 2016

I completed the CLA here earlier today. https://js.foundation/CLA/

@markstos

This comment has been minimized.

Contributor

markstos commented Nov 1, 2016

Apparently I used the wrong from last time. CLA issue is now resolved.

@ichernev

This comment has been minimized.

Contributor

ichernev commented Nov 4, 2016

Still displays yellow for me.

@JSFOwner

This comment has been minimized.

Member

JSFOwner commented Nov 5, 2016

The reason this is failing is because the author is @schempy and not @markstos so @schempy needs to sign.

@markstos

This comment has been minimized.

Contributor

markstos commented Nov 5, 2016

@schempy could you sign the Contributor License Agreement by following this link? https://cla.js.foundation/moment/moment?pullRequest=3515

@schempy

This comment has been minimized.

Contributor

schempy commented Nov 6, 2016

@markstos I signed the CLA.

@ichernev ichernev removed the cla-problem label Nov 6, 2016

@ichernev

This comment has been minimized.

Contributor

ichernev commented Nov 6, 2016

@schempy thank you!

@ichernev

This comment has been minimized.

Contributor

ichernev commented Nov 6, 2016

Merged in 47cffae

@ichernev ichernev changed the title from Fix #2300: Default to current week. to [feature] Fix #2300: Default to current week. Nov 6, 2016

@ichernev ichernev closed this Nov 6, 2016

ichernev added a commit that referenced this pull request Nov 6, 2016

Merge pull request #3515 from markstos:hotfix-issue-2300
[feature] Fix #2300: Default to current week.

@mj1856 mj1856 added Bug-fix and removed Pending Next Release labels Nov 10, 2016

@mj1856 mj1856 added this to the 2.16.0 milestone Nov 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment