Skip to content

[new locale] sd: Sindhi locale - #3659

Closed
narainsagar wants to merge 1 commit into
moment:developfrom
narainsagar:sindhi-locale-support
Closed

[new locale] sd: Sindhi locale#3659
narainsagar wants to merge 1 commit into
moment:developfrom
narainsagar:sindhi-locale-support

Conversation

@narainsagar

@narainsagar narainsagar commented Dec 13, 2016

Copy link
Copy Markdown
Contributor

Hi, I have added support for Sindhi language translation, It is very basic module and For most cases, I think these changes should suffice.

Unit tests are included as well.

Thanks for the great library! 👍

Cheers,

Global summary:
┌───────┬───────┬────────────┬────────┬────────┬─────────┐
│ Files │ Tests │ Assertions │ Failed │ Passed │ Runtime │
├───────┼───────┼────────────┼────────┼────────┼─────────┤
│ 1     │ 2892  │ 119091     │ 0      │ 119091 │ 10429   │
└───────┴───────┴────────────┴────────┴────────┴─────────┘

Running "exec:typescript-test" (exec) task

Done, without errors.

@jsf-clabot

jsf-clabot commented Dec 13, 2016

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@narainsagar narainsagar mentioned this pull request Dec 13, 2016
@narainsagar

narainsagar commented Jan 8, 2017

Copy link
Copy Markdown
Contributor Author

@maggiepint @Oire Any update on this when you'll merge this? OR any code reviews OR anything needs to be done on my end to get this merged? Thanks

@Menelion

Menelion commented Jan 8, 2017

Copy link
Copy Markdown

@maggiepint, should I ask someone for a review? It seems, several people have reacted with a thumbs-up...

@maggiepint

Copy link
Copy Markdown
Member

This is fine. We will ship when we get around to next release.

@ichernev

ichernev commented Mar 2, 2017

Copy link
Copy Markdown
Contributor

Merged in ef0f548

@ichernev ichernev changed the title Added Sindhi locale support + unit tests [new locale] sd: Sindhi locale Mar 2, 2017
@ichernev ichernev closed this Mar 2, 2017
ichernev added a commit that referenced this pull request Mar 2, 2017
@narainsagar
narainsagar deleted the sindhi-locale-support branch June 8, 2018 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants