Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new locale] sd: Sindhi locale #3659



Copy link

@narainsagar narainsagar commented Dec 13, 2016

Hi, I have added support for Sindhi language translation, It is very basic module and For most cases, I think these changes should suffice.

Unit tests are included as well.

Thanks for the great library! πŸ‘


Global summary:
β”‚ Files β”‚ Tests β”‚ Assertions β”‚ Failed β”‚ Passed β”‚ Runtime β”‚
β”‚ 1     β”‚ 2892  β”‚ 119091     β”‚ 0      β”‚ 119091 β”‚ 10429   β”‚

Running "exec:typescript-test" (exec) task

Done, without errors.

Copy link

jsf-clabot commented Dec 13, 2016

CLA assistant check
All committers have signed the CLA.

@narainsagar narainsagar mentioned this pull request Dec 13, 2016
Copy link
Contributor Author

narainsagar commented Jan 8, 2017

@maggiepint @Oire Any update on this when you'll merge this? OR any code reviews OR anything needs to be done on my end to get this merged? Thanks

Copy link

Menelion commented Jan 8, 2017

@maggiepint, should I ask someone for a review? It seems, several people have reacted with a thumbs-up...

Copy link

This is fine. We will ship when we get around to next release.

Copy link

ichernev commented Mar 2, 2017

Merged in ef0f548

@ichernev ichernev changed the title Added Sindhi locale support + unit tests [new locale] sd: Sindhi locale Mar 2, 2017
@ichernev ichernev closed this Mar 2, 2017
ichernev added a commit that referenced this pull request Mar 2, 2017
@narainsagar narainsagar deleted the sindhi-locale-support branch June 8, 2018 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

6 participants