Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new locale] sd: Sindhi locale #3659

Closed
wants to merge 1 commit into from
Closed

[new locale] sd: Sindhi locale #3659

wants to merge 1 commit into from

Conversation

narainsagar
Copy link
Contributor

@narainsagar narainsagar commented Dec 13, 2016 •
edited

Hi, I have added support for Sindhi language translation, It is very basic module and For most cases, I think these changes should suffice.

Unit tests are included as well.

Thanks for the great library! 👍

Cheers,

Global summary:
┌───────┬───────┬────────────┬────────┬────────┬─────────┐
│ Files │ Tests │ Assertions │ Failed │ Passed │ Runtime │
├───────┼───────┼────────────┼────────┼────────┼─────────┤
│ 1     │ 2892  │ 119091     │ 0      │ 119091 │ 10429   │
└───────┴───────┴────────────┴────────┴────────┴─────────┘

Running "exec:typescript-test" (exec) task

Done, without errors.

@jsf-clabot
Copy link

jsf-clabot commented Dec 13, 2016 •
edited

CLA assistant check
All committers have signed the CLA.

@narainsagar narainsagar mentioned this pull request Dec 13, 2016
Closed
@narainsagar
Copy link
Contributor Author

narainsagar commented Jan 8, 2017 •
edited

@maggiepint @Oire Any update on this when you'll merge this? OR any code reviews OR anything needs to be done on my end to get this merged? Thanks

@Menelion
Copy link

Menelion commented Jan 8, 2017

@maggiepint, should I ask someone for a review? It seems, several people have reacted with a thumbs-up...

@maggiepint
Copy link
Member

This is fine. We will ship when we get around to next release.

@mattjohnsonpint mattjohnsonpint modified the milestone: 2.18.0 Jan 17, 2017
@narainsagar narainsagar mentioned this pull request Feb 28, 2017
Closed
@ichernev
Copy link
Contributor

ichernev commented Mar 2, 2017

Merged in ef0f548

@ichernev ichernev changed the title Added Sindhi locale support + unit tests [new locale] sd: Sindhi locale Mar 2, 2017
@ichernev ichernev closed this Mar 2, 2017
ichernev added a commit that referenced this pull request Mar 2, 2017
@ichernev
Merge pull request #3659 from narainsagar:sindhi-locale-support
ef0f548 
[new locale] sd: Sindhi locale
@narainsagar narainsagar deleted the sindhi-locale-support branch June 8, 2018 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Language Pending Next Release
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@narainsagar @jsf-clabot @Menelion @maggiepint @ichernev @mattjohnsonpint