[new locale] sd: Sindhi locale - #3659
Closed
narainsagar wants to merge 1 commit into
Closed
Conversation
Closed
Contributor
Author
|
@maggiepint @Oire Any update on this when you'll merge this? OR any code reviews OR anything needs to be done on my end to get this merged? Thanks |
|
@maggiepint, should I ask someone for a review? It seems, several people have reacted with a thumbs-up... |
Member
|
This is fine. We will ship when we get around to next release. |
Contributor
|
Merged in ef0f548 |
ichernev
added a commit
that referenced
this pull request
Mar 2, 2017
[new locale] sd: Sindhi locale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I have added support for Sindhi language translation, It is very basic module and For most cases, I think these changes should suffice.
Unit tests are included as well.
Thanks for the great library! 👍
Cheers,