Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[locale] zh-cn,zh-hk,zh-tw: Change date formats according to CLDR #3952

Merged
merged 1 commit into from Dec 17, 2017

Conversation

Projects
None yet
6 participants
@monkeycon
Copy link
Contributor

monkeycon commented May 9, 2017

fixing for locale formats

@jsf-clabot

This comment has been minimized.

Copy link

jsf-clabot commented May 9, 2017

CLA assistant check
All committers have signed the CLA.

@maggiepint

This comment has been minimized.

Copy link
Member

maggiepint commented May 13, 2017

We have run around in circles with the Chinese locales lately. Can you provide a CLDR reference for these changes?

monkeycon

@monkeycon monkeycon force-pushed the monkeycon:fix-locale-zh branch from 718a621 to fad26b0 May 18, 2017

@monkeycon

This comment has been minimized.

Copy link
Contributor Author

monkeycon commented May 18, 2017

I updated the PR according to CLDR.
zh-cn:
http://www.unicode.org/repos/cldr/tags/release-31-0-1/common/main/zh.xml
zh-hk:
http://www.unicode.org/repos/cldr/tags/release-31-0-1/common/main/zh_Hans_HK.xml
zh-tw:
http://www.unicode.org/repos/cldr/tags/release-31-0-1/common/main/zh_Hant.xml
Ctrl+f <calendar type="gregorian">

ps: the locale zh-hk is a little special. it use D/M/YYYY for short (like UK), and YYYY年M月D日 for others.
in the PR, i use YYYY/M/D and YYYY/MM/DD for short (same as zh-cn).

@ichernev

This comment has been minimized.

Copy link
Contributor

ichernev commented Aug 3, 2017

@suupic @zenozeng any comments on that?

@ichernev ichernev changed the title Fix locale zh-* [locale] zh-cn,zh-hk,zh-tw: Fix locale zh-* Aug 3, 2017

@ichernev ichernev changed the title [locale] zh-cn,zh-hk,zh-tw: Fix locale zh-* [locale] zh-cn,zh-hk,zh-tw: Change date formats according to CLDR Aug 3, 2017

@JLHwung

This comment has been minimized.

Copy link
Contributor

JLHwung commented Sep 16, 2017

LGTM as a native speaker.

@marwahaha marwahaha changed the title [locale] zh-cn,zh-hk,zh-tw: Change date formats according to CLDR [local] zh-cn,zh-hk,zh-tw: Change date formats according to CLDR Dec 11, 2017

@marwahaha marwahaha changed the title [local] zh-cn,zh-hk,zh-tw: Change date formats according to CLDR [locale] zh-cn,zh-hk,zh-tw: Change date formats according to CLDR Dec 11, 2017

@marwahaha marwahaha merged commit 3209c75 into moment:develop Dec 17, 2017

3 checks passed

Title Your title looks great!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

afc163 added a commit to react-component/calendar that referenced this pull request Dec 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.