New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix year setter for random days in leap year #4255

Merged
merged 1 commit into from Nov 4, 2017

Conversation

Projects
None yet
3 participants
@Kerumen
Contributor

Kerumen commented Oct 19, 2017

When changing a year from a random day (not the 29th of february) of a leap year, the day is shifted to the end of the month.

Fixes #4238

@maggiepint

This comment has been minimized.

Show comment
Hide comment
@maggiepint

maggiepint Oct 19, 2017

Member

LGTM

Member

maggiepint commented Oct 19, 2017

LGTM

@kotapeter

This comment has been minimized.

Show comment
Hide comment
@kotapeter

kotapeter commented Nov 4, 2017

👍

@maggiepint

This comment has been minimized.

Show comment
Hide comment
@maggiepint

maggiepint Nov 4, 2017

Member

I'm going to merge this just so people can ref develop from npm if they like.

Member

maggiepint commented Nov 4, 2017

I'm going to merge this just so people can ref develop from npm if they like.

@maggiepint maggiepint merged commit 6beb383 into moment:develop Nov 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@Kerumen Kerumen deleted the Kerumen:fix-setYearLeapYear branch Nov 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment