New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix #4251: Avoid RFC2822 in utc() test #4312

Merged
merged 1 commit into from Dec 17, 2017

Conversation

Projects
None yet
3 participants
@ashsearle
Contributor

ashsearle commented Nov 20, 2017

In zh-cn locale (among others) the end of string with format (timezone offset) unit-test attempts to create two dates using RFC formatted strings passed to moment.utc() with explicit format strings.

This fails because it tries to parse the month and day-of-week using the users locale (zh-cn) instead of the English required to parse RFC2822.

This PR removes the locale-specific formatting from the unit-test.

Fixes #4251

@ashsearle ashsearle changed the title from Fix #4241: Avoid RFC2822 in utc() test to Fix #4251: Avoid RFC2822 in utc() test Nov 20, 2017

@ashsearle ashsearle changed the title from Fix #4251: Avoid RFC2822 in utc() test to [bugfix] Fix #4251: Avoid RFC2822 in utc() test Nov 20, 2017

@icambron

This comment has been minimized.

Member

icambron commented Nov 29, 2017

LGTM

@icambron

This comment has been minimized.

Member

icambron commented Nov 29, 2017

@ashsearle you never answered my email, btw

@marwahaha marwahaha merged commit d784038 into moment:develop Dec 17, 2017

3 checks passed

Title Your title looks great!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment