New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Added HTML5_FMT to moment.d.ts #4495

Merged
merged 2 commits into from Apr 4, 2018

Conversation

Projects
None yet
3 participants
@Calidus
Contributor

Calidus commented Mar 12, 2018

Resolved issue #4494

@Calidus Calidus changed the title from Added HTML5_FMT to moment.d.ts to [bugfix]Added HTML5_FMT to moment.d.ts Mar 12, 2018

@Calidus Calidus changed the title from [bugfix]Added HTML5_FMT to moment.d.ts to [bugfix] Added HTML5_FMT to moment.d.ts Mar 13, 2018

@ragingdave

This comment has been minimized.

ragingdave commented Mar 27, 2018

Any update on this? Running into the same issue

moment.d.ts Outdated
@@ -716,6 +716,19 @@ declare namespace moment {
export var defaultFormat: string;
export var defaultFormatUtc: string;
export var HTML5_FMT: {
DATETIME_LOCAL:string,

This comment has been minimized.

@ragingdave

ragingdave Mar 27, 2018

I would guess that the styling here would need to be updated prior to it being approved for merging so that like the code above it, there should be a space after the colon and the type.

This comment has been minimized.

@Calidus

Calidus Mar 28, 2018

Contributor

Oh good call. I have updated it.

@marwahaha

This comment has been minimized.

Member

marwahaha commented Apr 2, 2018

Thanks for this! The build errors will be fixed by #4525 .

@marwahaha marwahaha merged commit 23104ff into moment:develop Apr 4, 2018

5 checks passed

Base branch Looks good!
Generated files No edits to generated files! :)
Title Your title looks great!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment