Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix #4698: Use ISO WeekYear for HTML5_FMT.WEEK #4700

Merged
merged 2 commits into from Dec 13, 2018

Conversation

@ashsearle
Copy link
Contributor

commented Jul 13, 2018

Use the ISO WeekYear GGGG in HTML5_FMT.WEEK constant.

Updated test cases for the formatting constants to use a date/time that fails with the old YYYY format, to prevent regressions.

Fixes #4698
Fixes #4833

@coveralls

This comment has been minimized.

Copy link

commented Jul 13, 2018

Coverage Status

Coverage decreased (-0.08%) to 94.563% when pulling 10a98e3 on ashsearle:fix/4698 into 2e2a5b3 on moment:develop.

@coveralls

This comment has been minimized.

Copy link

commented Jul 13, 2018

Coverage Status

Coverage increased (+0.0007%) to 88.136% when pulling 3fa1520 on ashsearle:fix/4698 into c68b4f1 on moment:develop.

@marwahaha

This comment has been minimized.

Copy link
Member

commented Oct 31, 2018

Looks great. can we add the additional test cases from #4833 and #4698 into this PR?

I think if you merge/rebase from develop your updated Travis builds will pass the tests. :)

@ashsearle ashsearle force-pushed the ashsearle:fix/4698 branch from 10a98e3 to 3fa1520 Oct 31, 2018
@marwahaha marwahaha removed the Needs tests label Dec 13, 2018
@marwahaha marwahaha merged commit 3147fbc into moment:develop Dec 13, 2018
6 checks passed
6 checks passed
Base branch Looks good!
Generated files No edits to generated files! :)
Title Your title looks great!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0007%) to 88.136%
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.