From 87fb1642040b19989910dd8520a1219c8694fe18 Mon Sep 17 00:00:00 2001 From: Matt Straathof Date: Thu, 21 Dec 2023 15:46:00 -0800 Subject: [PATCH] chore: ttl should be duration not int --- lib/src/cache_client.dart | 6 +++--- lib/src/internal/data_client.dart | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/src/cache_client.dart b/lib/src/cache_client.dart index c71f972..daac88c 100644 --- a/lib/src/cache_client.dart +++ b/lib/src/cache_client.dart @@ -12,7 +12,7 @@ abstract class ICacheClient { Future get(String cacheName, Value value); Future set(String cacheName, Value key, Value value, - {int? ttlSeconds}); + {Duration? ttl}); } class CacheClient implements ICacheClient { @@ -34,7 +34,7 @@ class CacheClient implements ICacheClient { @override Future set(String cacheName, Value key, Value value, - {int? ttlSeconds}) { - return _dataClient.set(cacheName, key, value, ttlSeconds: ttlSeconds); + {Duration? ttl}) { + return _dataClient.set(cacheName, key, value, ttl: ttl); } } diff --git a/lib/src/internal/data_client.dart b/lib/src/internal/data_client.dart index 78b7211..3f4338b 100644 --- a/lib/src/internal/data_client.dart +++ b/lib/src/internal/data_client.dart @@ -13,7 +13,7 @@ abstract class AbstractDataClient { Future get(String cacheName, Value key); Future set(String cacheName, Value key, Value value, - {int? ttlSeconds}); + {Duration? ttl}); } class DataClient implements AbstractDataClient { @@ -64,12 +64,12 @@ class DataClient implements AbstractDataClient { @override Future set(String cacheName, Value key, Value value, - {int? ttlSeconds}) async { + {Duration? ttl}) async { var request = SetRequest_(); request.cacheKey = key.toBinary(); request.cacheBody = value.toBinary(); - request.ttlMilliseconds = (ttlSeconds != null - ? ttlSeconds * 1000 + request.ttlMilliseconds = (ttl != null + ? ttl.inMilliseconds : _defaultTtl.inMilliseconds) as Int64; try { await _client.set(request,