From d6f49e952c471d6816c042d05c8817de71afba15 Mon Sep 17 00:00:00 2001 From: anitarua Date: Fri, 8 Nov 2024 10:33:48 -0800 Subject: [PATCH 1/3] chore: make release-please version consistent with the other sdks --- .github/workflows/on-push-to-main-branch.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/on-push-to-main-branch.yml b/.github/workflows/on-push-to-main-branch.yml index a288bdc6..e42b04ad 100644 --- a/.github/workflows/on-push-to-main-branch.yml +++ b/.github/workflows/on-push-to-main-branch.yml @@ -35,7 +35,7 @@ jobs: steps: - uses: actions/checkout@v4 - - uses: googleapis/release-please-action@v4 + - uses: googleapis/release-please-action@v3 name: Release Please id: release with: From c6442216df29297333597be9a7fd11b553127040 Mon Sep 17 00:00:00 2001 From: anitarua Date: Mon, 11 Nov 2024 09:28:04 -0800 Subject: [PATCH 2/3] specify manifest instead of downgrading release-please action --- .github/workflows/on-push-to-main-branch.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/on-push-to-main-branch.yml b/.github/workflows/on-push-to-main-branch.yml index e42b04ad..038eb7ae 100644 --- a/.github/workflows/on-push-to-main-branch.yml +++ b/.github/workflows/on-push-to-main-branch.yml @@ -35,14 +35,13 @@ jobs: steps: - uses: actions/checkout@v4 - - uses: googleapis/release-please-action@v3 + - uses: googleapis/release-please-action@v4 name: Release Please id: release with: token: ${{ secrets.MOMENTO_MACHINE_USER_GITHUB_TOKEN }} release-type: python - default-branch: main - changelog-types: '[{"type":"feat","section":"Features","hidden":false},{"type":"fix","section":"Bug Fixes","hidden":false},{"type":"chore","section":"Miscellaneous","hidden":false}]' + manifest-file: .release-please-manifest.json publish: needs: [release-please] From c9a2bdabaa9fa9d4e8ef68069b0b21ce0de6c94a Mon Sep 17 00:00:00 2001 From: anitarua Date: Tue, 12 Nov 2024 14:38:54 -0800 Subject: [PATCH 3/3] try putting all configs in manifest --- .github/workflows/on-push-to-main-branch.yml | 2 -- .release-please-manifest.json | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/on-push-to-main-branch.yml b/.github/workflows/on-push-to-main-branch.yml index 038eb7ae..45f44db0 100644 --- a/.github/workflows/on-push-to-main-branch.yml +++ b/.github/workflows/on-push-to-main-branch.yml @@ -40,8 +40,6 @@ jobs: id: release with: token: ${{ secrets.MOMENTO_MACHINE_USER_GITHUB_TOKEN }} - release-type: python - manifest-file: .release-please-manifest.json publish: needs: [release-please] diff --git a/.release-please-manifest.json b/.release-please-manifest.json index 040fdac5..eef6b4ec 100644 --- a/.release-please-manifest.json +++ b/.release-please-manifest.json @@ -1,4 +1,5 @@ { + "release-type": "python", "changelog-sections": [ { "type": "feat",