From db315f90822390199f502cedd09a4394a7a10f78 Mon Sep 17 00:00:00 2001 From: gautamomento Date: Thu, 4 Nov 2021 10:36:10 -0700 Subject: [PATCH 1/4] fix: Push always uses default version --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 6a8bdb14..4e17e79e 100644 --- a/setup.py +++ b/setup.py @@ -1,11 +1,11 @@ import setuptools import os -import time version = os.getenv("MOMENTO_SDK_VERSION") if [version == None]: version = '0.0.dev' + print('version:' + version) # version is the only dynamic configuration setuptools.setup( From 96a440cd05a3609977d4212513258cec9b461102 Mon Sep 17 00:00:00 2001 From: gautamomento Date: Thu, 4 Nov 2021 10:50:14 -0700 Subject: [PATCH 2/4] fix if statement --- setup.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/setup.py b/setup.py index 4e17e79e..09efd2f1 100644 --- a/setup.py +++ b/setup.py @@ -3,9 +3,8 @@ version = os.getenv("MOMENTO_SDK_VERSION") -if [version == None]: - version = '0.0.dev' - print('version:' + version) +if (version is None): + version = '0.0.localdev0' # version is the only dynamic configuration setuptools.setup( From 78015a0fe389165aa39afccc1ec6f25cd80d5552 Mon Sep 17 00:00:00 2001 From: gautamomento Date: Thu, 4 Nov 2021 10:53:27 -0700 Subject: [PATCH 3/4] fix build script --- .github/workflows/pull_request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 9be2a5fc..a8e6e7d4 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -29,6 +29,6 @@ jobs: run: | set -e set -x - export PYPI_MOMENTO_WIRE_TYPE_VERSION=0.0.devBuild + export MOMENTO_SDK_VERSION=0.0.devBuild python -m build shell: bash From 43cd1bb98b0892d1943097a70387932faa10f7dc Mon Sep 17 00:00:00 2001 From: gautamomento Date: Thu, 4 Nov 2021 11:12:44 -0700 Subject: [PATCH 4/4] fix formatting --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 09efd2f1..247a5b1d 100644 --- a/setup.py +++ b/setup.py @@ -3,7 +3,7 @@ version = os.getenv("MOMENTO_SDK_VERSION") -if (version is None): +if(version is None): version = '0.0.localdev0' # version is the only dynamic configuration