Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microlens-th fails to build against microlens 0.4.10 #122

Closed
hpdeifel opened this issue Jun 18, 2019 · 3 comments
Closed

microlens-th fails to build against microlens 0.4.10 #122

hpdeifel opened this issue Jun 18, 2019 · 3 comments

Comments

@hpdeifel
Copy link

@hpdeifel hpdeifel commented Jun 18, 2019

cabal unpack microlens-th
cd microlens-th-0.4.3
cabal new-build --constraint 'microlens ==0.4.10'
Resolving dependencies...
Build profile: -w ghc-8.6.3 -O1
In order, the following will be built (use -v for more details):
 - microlens-th-0.4.3 (lib) (configuration changed)
Configuring library for microlens-th-0.4.3..
Preprocessing library for microlens-th-0.4.3..
Building library for microlens-th-0.4.3..
[1 of 1] Compiling Lens.Micro.TH    ( src/Lens/Micro/TH.hs, somewhere/microlens-th-0.4.3/dist-newstyle/build/x86_64-linux/ghc-8.6.3/microlens-th-0.4.3/build/Lens/Micro/TH.o ) [Lens.Micro.Internal changed]

src/Lens/Micro/TH.hs:84:1: error:
    Lens.Micro.Internal: Can't be safely imported!
    The module itself isn't safe.
   |
84 | import           Lens.Micro.Internal (phantom)
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I only noticed this because some package in my dependency tree depends on microlens<0.4.11 and consequently my CI stated failing.

@neongreen

This comment has been minimized.

Copy link
Member

@neongreen neongreen commented Jun 18, 2019

Thanks! I'm going to revert the assignment of Trustworthy status to Lens.Micro.Internal – after further investigation it looks kinda shady. I will also deprecate affected versions and make patch releases.

@neongreen

This comment has been minimized.

Copy link
Member

@neongreen neongreen commented Jun 20, 2019

Done.

@neongreen neongreen closed this Jun 20, 2019
@hpdeifel

This comment has been minimized.

Copy link
Author

@hpdeifel hpdeifel commented Jun 24, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.