Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global object-> changes comment #224

Closed
jerolomb opened this issue Dec 23, 2019 · 2 comments
Closed

Global object-> changes comment #224

jerolomb opened this issue Dec 23, 2019 · 2 comments

Comments

@jerolomb
Copy link
Contributor

@jerolomb jerolomb commented Dec 23, 2019

Describe the bug
In a global object, you modify the value "existing control" it changes the value for all the risks of the asset.

Precondition : database is corrupted, all the risks in instances_risks table have the same amv_id

To Reproduce
Steps to reproduce the behavior:

  1. Have a corrupted database
  2. instantiate two times the object
  3. change one value "existing control"
  4. See error

Expected behavior
Change only the value to the expected instance_risks and its brothers.

Questions Answers
Type of issue Bug
OS version (server) Ubuntu 16.04
OS version (client) not relevant
PHP version not relevant
MONARC version / git hash 2.9.5,
Browser Firefox, Chrome,
jerolomb added a commit to monarc-project/zm-core that referenced this issue Dec 23, 2019
@jerolomb

This comment has been minimized.

Copy link
Contributor Author

@jerolomb jerolomb commented Dec 23, 2019

I ve just changed a condition to not only check on the amv_id. We also need to make a phinx script to correct the corrupted database

@ruslanbaidan ruslanbaidan added this to To do in MONARC Development Overview via automation Jan 6, 2020
@ruslanbaidan

This comment has been minimized.

Copy link
Contributor

@ruslanbaidan ruslanbaidan commented Jan 6, 2020

We can fix the database consistency if it is required manually by cooperation with the customer(s) who has the problem. We can also keep it like this as far the performed fix will prevent having the issue in the future.

MONARC Development Overview automation moved this from To do to Done Jan 6, 2020
ruslanbaidan added a commit to monarc-project/zm-core that referenced this issue Jan 9, 2020
* origin/master:
  Added the methods to link and unlink categories to/from anrs when it become root or removed from root.
  Changed usage of the client database for DeliveriesModelsEntity.
  Added the method return type.
  Fixed the removal of the all not linked recommendations from the knowledge base of an anr during object detach, now we remove only relations.
  Updated copyright years.
  Siplifyed the service by moving the DB operations to the specific table classes.
  comment monarc-project/MonarcAppFO#226 it seems this condition is the issue, works well without.
  comment monarc-project/MonarcAppFO#225 let Monarc handle the id management
  comment monarc-project/MonarcAppFO#224
  Fixed the issue of removing of the library categories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
MONARC Development Overview
  
Done (deployed on prod)
2 participants
You can’t perform that action at this time.