Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent id and global asset #225

Closed
jerolomb opened this issue Dec 23, 2019 · 1 comment
Closed

Inconsistent id and global asset #225

jerolomb opened this issue Dec 23, 2019 · 1 comment

Comments

@jerolomb
Copy link
Contributor

@jerolomb jerolomb commented Dec 23, 2019

Describe the bug
The field instance_id in the table instances_risks become false when modifying an instance_risk of a global asset.

To Reproduce
Steps to reproduce the behavior:

  1. Create an analysis like this :
    image

DB view :
image

  1. Edit the vulnerability qualification for the first "gestion des backups"
    image

Go now to the second "gestion des backups" and a risk is not visible
image

DB view :
it creates multiple risks not visible in the view in the ANR and change the instance_id of one field (id 63197)
image

Expected behavior
Works properly

Desktop (please complete the following information):

Questions Answers
Type of issue Bug
OS version (server) Ubuntu
OS version (client) Win10,
PHP version 7.2
MONARC version / git hash 2.9.5,
Browser Firefox, Chrome

Additional context
Present in local VM and production in the cloud

@jerolomb jerolomb added the bug label Dec 23, 2019
jerolomb added a commit to monarc-project/zm-core that referenced this issue Dec 23, 2019
@ruslanbaidan ruslanbaidan added this to To do in MONARC Development Overview via automation Jan 6, 2020
@ruslanbaidan ruslanbaidan moved this from To do to Reviewer approved in MONARC Development Overview Jan 6, 2020
@ruslanbaidan

This comment has been minimized.

Copy link
Contributor

@ruslanbaidan ruslanbaidan commented Jan 7, 2020

Fixed and deployed

MONARC Development Overview automation moved this from Reviewer approved to Done Jan 7, 2020
ruslanbaidan added a commit to monarc-project/zm-core that referenced this issue Jan 9, 2020
* origin/master:
  Added the methods to link and unlink categories to/from anrs when it become root or removed from root.
  Changed usage of the client database for DeliveriesModelsEntity.
  Added the method return type.
  Fixed the removal of the all not linked recommendations from the knowledge base of an anr during object detach, now we remove only relations.
  Updated copyright years.
  Siplifyed the service by moving the DB operations to the specific table classes.
  comment monarc-project/MonarcAppFO#226 it seems this condition is the issue, works well without.
  comment monarc-project/MonarcAppFO#225 let Monarc handle the id management
  comment monarc-project/MonarcAppFO#224
  Fixed the issue of removing of the library categories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
MONARC Development Overview
  
Done (deployed on prod)
2 participants
You can’t perform that action at this time.