Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomly deletion of recommendations #228

Closed
jerolomb opened this issue Dec 24, 2019 · 3 comments
Closed

Randomly deletion of recommendations #228

jerolomb opened this issue Dec 24, 2019 · 3 comments
Assignees
Labels
bug

Comments

@jerolomb
Copy link
Contributor

@jerolomb jerolomb commented Dec 24, 2019

Describe the bug
Detach an asset of the anr delete all or a part of all the recommendations.

To Reproduce
Steps to reproduce the behavior:

  1. Create a risk analysis like this
    image

  2. Create and attach a recommendation to an asset witch has something common (vulnerability, threat etc.) with the other one
    image

  3. Detach the assets which are not linked to the recommendations

  4. The recommendations are also deleted

Expected behavior
The recommendation mustn't be deleted

Desktop (please complete the following information):

Questions Answers
Type of issue Bug
OS version (server) Ubuntu, ...
OS version (client) Win10
PHP version 7.2
MONARC version / git hash 2.9.5,
Browser Firefox

Additional context
Tested on production and local machine
The scenario is maybe not the only one. But it helps to reproduce the bug.

@ruslanbaidan

This comment has been minimized.

Copy link
Contributor

@ruslanbaidan ruslanbaidan commented Jan 3, 2020

There are 2 PRs to fix the issue:
monarc-project/zm-client#16
monarc-project/zm-core#20
Might be we need to reorder recommendations after an object removal, needs to be clarified with @jerolomb .

@ruslanbaidan

This comment has been minimized.

Copy link
Contributor

@ruslanbaidan ruslanbaidan commented Jan 3, 2020

Deployed on formation:
https://formation.monarc.lu

@ruslanbaidan

This comment has been minimized.

Copy link
Contributor

@ruslanbaidan ruslanbaidan commented Jan 7, 2020

Deployed on prod

MONARC Development Overview automation moved this from In progress to Done Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
MONARC Development Overview
  
Done (deployed on prod)
2 participants
You can’t perform that action at this time.