Skip to content

Capitalisation rules for disease names #6332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
azankl opened this issue Jun 8, 2023 · 3 comments · Fixed by #6348
Closed

Capitalisation rules for disease names #6332

azankl opened this issue Jun 8, 2023 · 3 comments · Fixed by #6348

Comments

@azankl
Copy link

azankl commented Jun 8, 2023

I noticed that some diseases in MONDO have their first letter capitalised, while others don't:

MONDO:0007037 achondroplasia
MONDO:0007041 apert syndrome
MONDO:0007043 Pfeiffer syndrome

I would prefer first letter capitalised, i.e. Achondroplasia.
In general, does MONDO have any rules on how to name diseases? I note that Orphanet has a whole protocol on how to name diseases and they recommend capitalising the first letter, as in Achondroplasia:
https://www.orpha.net/orphacom/cahiers/docs/GB/eproc_Disease_naming_rules_in_English_PR_R1_Nom_01.pdf

Does MONDO have something similar?

see also my related question about the dyadic approach to disease naming #6333 (comment)

Your nano-attribution (ORCID)
0000-0001-8612-1062

@cmungall
Copy link
Member

cmungall commented Jun 8, 2023

This is standard naming convention for ontologies and is an OBO principle: https://obofoundry.org/principles/fp-012-naming-conventions.html

It's a principle for a very good reason.

If I have an application where I want to place an ontology term in a sentence, then this is wrong with leading upper case:

the genes implicated in Lung cancer are ...

Also title case as used by NCIT is also wrong

the genes implicated in Lung Cancer are ...

And all-caps is also poor style

the genes implicated in LUNG CANCER are ...

It's hard to reliably downcase due to the presence of proper names in diseases; this is wrong:

the genes implicated in parkinson disease are ...

In contrast, if an application really wants to see leading upper case or title case, or even all-caps, this is a deterministic transformation without any ad-hoc rules

It's a good question, I'll leave it open for now until we add to our FAQ, then we'll close it, unless there are any further clarifications sought...

@azankl
Copy link
Author

azankl commented Jun 9, 2023

Thought you would have a good reason, that's why I asked ;-)
Agree with the concept of using lower case unless it's a proper name, but would argue that most rare diseases have a proper name. So all of the following should be capitalised as below (they are currently all lower case):

MONDO_ID Name
MONDO:0007037 Achondroplasia
MONDO:0007041 Apert syndrome
MONDO:0007044 Acrodysostosis 1 with or without hormone resistance
MONDO:0007055 Acromicric dysplasia
MONDO:0007057 Acroosteolysis dominant type
MONDO:0007058 Acropectorovertebral dysplasia
MONDO:0007073 Hypoglossia-hypodactyly syndrome
MONDO:0007078 Pseudohypoparathyroidism type 1A
MONDO:0007114 Angel-shaped phalango-epiphyseal dysplasia
MONDO:0007124 Ankyloblepharon-ectodermal defects-cleft lip/palate syndrome

Would you agree? If yes, I will go through the list of skeletal dysplasias and submit tickets where the capitalisation is wrong.

@nicolevasilevsky
Copy link
Member

Yes, we agree with your expert opinion, thanks @azankl. I updated the labels for the term above. Thanks for reviewing the other skeletal dysplasias, please report new tickets. Thank you!

nicolevasilevsky added a commit that referenced this issue Jun 13, 2023
* capitalize first letter

address #6332

* save as
nicolevasilevsky added a commit that referenced this issue Jun 13, 2023
address #6332
nicolevasilevsky added a commit that referenced this issue Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants