/owlsim-v3

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Unused code elements in NaiveBayesFixedWeightThreeStateProfileMatcher #50

Open
drseb opened this Issue Feb 8, 2017 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@drseb @cmungall
@drseb
Owner

drseb commented Feb 8, 2017

The set nodesQfPu is initialized, but it seems that nothing get added to this set. It is later transformed to the Bitmap nodesQfPuBM which is used to determine some andCardinality and andNot.

This seems wrong to me. Can you clarify?
@drseb
Owner

drseb commented Feb 8, 2017 • edited

It also seems to me that the following is also unused:

EWAHCompressedBitmap queryNegatedNoTransitionBM = getQueryNegatedNoTransition(nodesQfBM);
EWAHCompressedBitmap queryNegatedWithTransitionBM = nodesQfBM.andNot(queryNegatedNoTransitionBM);

line 160
@cmungall
Owner

cmungall commented Feb 9, 2017

I can clarify something is up here.

Will investigate...

@drseb drseb changed the title from NaiveBayesFixedWeightThreeStateProfileMatcher: nodesQfPu to Unused code elements in NaiveBayesFixedWeightThreeStateProfileMatcher Feb 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment