Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Parameter choice leading to '-Inf' in NaiveBayesFixedWeightThreeStateProfileMatcher #51
Comments
drseb
changed the title from
Parameter choice leading to '-Inf' to Parameter choice leading to '-Inf' in NaiveBayesFixedWeightThreeStateProfileMatcher
Feb 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
drseb commentedFeb 9, 2017
If
prWeakTrueMissis too small (right now it is 0.85), we are introducing-Infin lines 335/336/338
In my code,
nQuHuPtin use with HPO becomes larger than 10,000. ThencprQuHuPt = Math.pow(0.85, 10000)is 0 and in line 338 we computeMath.log(cprQuHuPt).Questions:
Do you get similar values for
nQuHuPt? (I have re-implemented your code, so not sure the problem is on my side)If yes, any thoughts on this? Increase
prWeakTrueMiss? But then we also have to significantly decreaseprWeakFalsePositive, because in line 329 we calculateMath.pow(1-(prWeakFalsePositive + prWeakTrueMiss), nQfHuPt).Any help greatly appreciated.