Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Make specific routes for the different matchers #63
Comments
cmungall
referenced this issue
Mar 3, 2017
Closed
Leakage of owlsim-server guice configuration into owlsim-core #62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cmungall commentedMar 3, 2017
Currently the route is
/match/{matcher}/...which on the one hand is nice as new matchers can easily be slotted in.
however, different matchers will have different parameterization, and may have differences in payloads. While this could be handled by generic property-value methods, not clear this abstraction is helpful. And it's not like we will have that many matchers in production. Or that it would be hard to add specific routes, it's not that much boilerplate.
It may be clearer to have distinct routes:
/match/phenodigm//match/bnb/Advantages: