Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add paging to ontomatch service #69

Open
cmungall opened this Issue Mar 10, 2017 · 5 comments

Comments

Projects
None yet
4 participants
Owner

cmungall commented Mar 10, 2017

The route '/ontolomatch/MP/HP' should return a set of best matches in MP for HP (note this is less than the full all-by-all table).

Currently this gives a gateway timeout. Paging should be added.

Also, we should have a version that works for a specific ID, @drseb would use this.

@jnguyenx jnguyenx was assigned by cmungall Mar 10, 2017

Owner

drseb commented Mar 13, 2017

I would also be happy with the full all-by-all table. How could I obtain this?

Contributor

julesjacobsen commented Mar 20, 2017

You should be able to just use the API directly:

BMKnowledgeBase bmKnowledgeBase = BMKnowledgeBase.owlLoader()...createKnowledgeBase();
ClassMatcher classMatcher= new ClassMatcher(bmKnowledgeBase);
List<SimpleClassMatch> matches =  classMatcher.matchOntologies("HP", "MP");
Collaborator

jnguyenx commented Mar 20, 2017

We had a look with Chris, it doesn't seem to be an issue with the returned data being too large. But the service takes too long to return anyway, Chris will take a look at that.

Owner

cmungall commented Mar 20, 2017

OK, great. To summarize:

  • for all by all, @drseb can use the java API directly
  • we can consider having a report exported somewhere, but I'd rather avoid this, see below
  • I'd still like this to be available as a service. We have a separate ticket to do a service query for any given class: #72
  • It should actually not be too hard to do all by all as a service. We just calculate this on initialization, possibly caching, driven by what is in the yaml. E.g. the yaml may say calculate all by all for {HP,MP,WBPhenotype,...}. (if you query a combo that is not in the yaml then you are out of luck). Given this is a bit fiddly and that other routes are available, I may classify this as 'nice to have' and punt until afterwards.
Owner

drseb commented Mar 22, 2017

I am happy with using the API. I am not closing, because the ticket is about something else now.

@jnguyenx jnguyenx removed their assignment Apr 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment