Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initially loading prop on a button appears broken #135

Closed
uri-shmueli opened this issue Jun 2, 2021 · 2 comments
Closed

Initially loading prop on a button appears broken #135

uri-shmueli opened this issue Jun 2, 2021 · 2 comments

Comments

@uri-shmueli
Copy link
Contributor

uri-shmueli commented Jun 2, 2021

When setting the loading prop to true (hardcoded/initially), we get an empty small box instead of a button with the loading animation

https://style.monday.com/?path=/story/components-button--loading

image

@uri-shmueli uri-shmueli changed the title test Initially loading prop on a button appears broken Jun 2, 2021
@adnansam110
Copy link

@uri-shmueli Can you assign this issue to me under hacktoberfest label ?

@talkor
Copy link
Member

talkor commented Nov 23, 2023

Hey @uri-shmueli, a bit late response but the Button now keeps its size when changing to a loading state, so this issue is resolved :) Thanks for reporting

@talkor talkor closed this as completed Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants