-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write translated Markdown documentation pages in temporal directory #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs(license): update copyright year(s) * docs(license): update copyright year(s) Co-authored-by: github-actions <github-actions@github.com>
…into fix-on_serve
Pull Request Test Coverage Report for Build 1898981712
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
This is done, the problem is that PO files inside
docs/
folder are written during the build, even if are written onpost_build
event. The possible solutions are:docs/
. It seems very convenient to store them there, but currently Mkdocs does not offer a way to write todocs/
without entering in a infinite reload loop when serving files. Just usinglocale_dir
and documeting it.LiveReloadServer
mkdocs/mkdocs#2777. This would allow to unwatch PO files. The problem here is that when PO file changes, it would not be reloaded, but this inconvenient doesn't seem very important anyways.Breaking changes
dest_filename_template
has been changed from{{language}}/{{page.file.dest_path}}
to{{language}}/{{file.dest_path}}
.