Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

CMakeLists.txt: use /etc/os-release to detect distro #913

Closed
Wuodan opened this issue Jun 15, 2018 · 2 comments
Closed

CMakeLists.txt: use /etc/os-release to detect distro #913

Wuodan opened this issue Jun 15, 2018 · 2 comments

Comments

@Wuodan
Copy link
Contributor

Wuodan commented Jun 15, 2018


By submitting this issue, I confirm the following:

  • I have read and understood the developer guide in kovri-docs.
  • I have checked that the issue I am reporting can be replicated or that the feature I am suggesting is not present.
  • I have checked opened or recently closed pull requests for existing solutions/implementations to my issue/suggestion.

CMakeLists.txt has a function Uname(), which I would like to replace.
Reason:
uname -a will never work here! I suggest using /etc/os-release to detect distro. My research shows that /etc/os-release should be available on recent versions of the currently supported distros Arch and Ubuntu plus many others.

@anonimal
Copy link
Collaborator

uname -a will never work here!

What do you mean by this? What is gentoo's output?

/etc/os-release

This is far less portable than uname so I would like to avoid this if possible.

@anonimal
Copy link
Collaborator

anonimal commented Sep 7, 2018

NOTICE: THIS ISSUE HAS BEEN MOVED TO GitLab. Please continue the discussion there. See #1013 for details.

@anonimal anonimal closed this as completed Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants