Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Tests: fix BookEntry naming warning #922

Merged
merged 1 commit into from Jun 26, 2018

Conversation

coneiric
Copy link
Contributor


By submitting this pull-request, I confirm the following:

  • I have read and understood the developer guide in kovri-docs.
  • I have checked that another pull-request for this purpose does not exist.
  • I have considered and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used and that this pull-request may be closed by the will of the maintainer.
  • I give this submission freely under the BSD 3-clause license.

Renames constructed entry objects for clarity, and resolves clang -Wuninitialized warning:

kovri/tests/unit_tests/client/address_book/impl.cc:177:51: warning: variable 'entry' is uninitialized when used within its own initialization [-Wuninitialized]                                                                                                      
      kovri::client::BookEntry entry("kovri.i2p", entry.get_address()));

Renames constructed objects inside Boost.Test macros for clarity,
and resolves clang compiler warning about uninitialized construction.
@anonimal anonimal merged commit 7ff4457 into monero-project:master Jun 26, 2018
anonimal added a commit that referenced this pull request Jun 26, 2018
7ff4457 Tests: fix BookEntry naming warning (oneiric)
@coneiric coneiric deleted the fix-entry-test branch July 13, 2018 03:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants