New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle daemon dialog window #1341

Merged
merged 6 commits into from Apr 27, 2018

Conversation

Projects
None yet
6 participants
@skftn
Contributor

skftn commented Apr 21, 2018

Fixes #1278

  • Makes the TitleBar component more modular
  • Move the black overlay (that covers the main window) to main.qml, visible when another window is active
  • Move Javascript code related to dialogs/windows to js/Windows.js
    • Dynamically set Window flags based off persistentSettings.customDecorations from this file
  • Timestamped output (via Utils.js)
  • Colors

@skftn

This comment has been minimized.

Contributor

skftn commented Apr 21, 2018

Review needed.

+help wanted

@skftn skftn changed the title from Restyle daemon dialog window to [RELEASE] Restyle daemon dialog window Apr 21, 2018

@MaxXor

Looks good overall and working fine on Debian 9. However the window has the system window style instead of the custom one used by the Monero GUI. I think this should be changed to have it consistent continuously in all window.

@skftn

This comment has been minimized.

Contributor

skftn commented Apr 22, 2018

@MaxXor Cool, thanks for trying it out.

Previously I've tried this with custom window decorations and I did not like the way it looked, also some people from IRC didn't like it as well so it was left out. Ill provide an image to show you today or tomorow.

@skftn skftn changed the title from [RELEASE] Restyle daemon dialog window to Restyle daemon dialog window Apr 23, 2018

@GBKS

GBKS approved these changes Apr 23, 2018

@pazos

pazos approved these changes Apr 25, 2018

@skftn

This comment has been minimized.

Contributor

skftn commented Apr 25, 2018

Rebased.

@skftn

This comment has been minimized.

Contributor

skftn commented Apr 25, 2018

@MaxXor Since this is a 'special window', (power users/debugging purposes), I'm leaving it without custom decorations.

@luigi1111 luigi1111 merged commit 75ccc7a into monero-project:master Apr 27, 2018

5 of 6 checks passed

buildbot/monero-gui-win64 Build done.
Details
buildbot/monero-gui-osx-10.11 Build done.
Details
buildbot/monero-gui-osx-10.13 Build done.
Details
buildbot/monero-gui-ubuntu-amd64 Build done.
Details
buildbot/monero-gui-ubuntu-i686 Build done.
Details
buildbot/monero-gui-win32 Build done.
Details

luigi1111 added a commit that referenced this pull request Apr 27, 2018

Merge pull request #1341
7d8d477 Redesigned the daemon console pop-up
acefb96 Added 'Windows.js' for dialogs/windows
47f9a17 Modify password dialog and move customdecorations function out of main.qml
4d56ed9 Make the titlebar more modular
7fe9d71 Added daemonConsole component to main.qml
75ccc7a Added Utils.js, for miscellaneous Javascript functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment