Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive page redesigned #1359

Merged
merged 15 commits into from May 7, 2018

Conversation

Projects
None yet
4 participants
@xmrdsc
Copy link
Contributor

xmrdsc commented Apr 28, 2018

Fixes #1262

Old:
https://i.imgur.com/DMLAYzs.png

New:

https://i.imgur.com/qPQLovm.png
https://i.imgur.com/IaZUsI2.png

  • Hover effect on rows, makes selecting individual addresses more intuitive
  • Narrower rows
  • The table is not a flickable region anymore, it will automatically expand as you get more addresses.
    • Pagination would be nice but not a priority. Must be implemented in C++.
  • 'fake' row on the bottom of the table that serves as a button to create more addresses.
  • Fixes the QR code 'newline' bug by adding white borders.
  • Redesigned the transaction tracking section.
    • Also refactored the js code behind it.
  • All sections/components are ready for mobile.
    • The truncated addresses in the table, truncate more when on mobile.
  • Dynamic page/panel height.

It also supports the 'check if the incoming transaction(s) satisfy the requested amount to receive' functionality:

https://i.imgur.com/Mlt5WgG.png

@xmrdsc xmrdsc force-pushed the xmrdsc:redesign-receive-page branch from 184dfb5 to 95b2a3e Apr 28, 2018

@xmrdsc xmrdsc changed the title [WIP] Receive page redesigned Receive page redesigned Apr 29, 2018

@erciccione erciccione referenced this pull request Apr 30, 2018

Closed

Update receive page #19

@pazos

This comment has been minimized.

Copy link
Contributor

pazos commented May 1, 2018

@skftn: good job, but you need to update the new icon:
Cannot find file 'images/editIcon.png'

@tficharmers
Copy link

tficharmers left a comment

I have reviewed the new Receive page with:
https://build.getmonero.org/builders/monero-gui-osx-10.13/builds/242

Pending a fix to the 'Create new address' pop up box (background missing), this is a big improvement and works as I would expect it to.

  • QR codes tested with/without amounts; QR image saved and works
  • tracking works
  • help messages work
  • creating new sub address and changing label works

@xmrdsc xmrdsc force-pushed the xmrdsc:redesign-receive-page branch from 60fe12f to bff2701 May 3, 2018

@xmrdsc

This comment has been minimized.

Copy link
Contributor Author

xmrdsc commented May 3, 2018

@pazos Included editIcon.png
@tficharmers Thanks for testing. Glad to know QR is fixed now.

Rebased. Code ready for review.

@pazos

pazos approved these changes May 5, 2018

@luigi1111 luigi1111 merged commit bff2701 into monero-project:master May 7, 2018

5 of 6 checks passed

buildbot/monero-gui-win64 Build done.
Details
buildbot/monero-gui-osx-10.11 Build done.
Details
buildbot/monero-gui-osx-10.13 Build done.
Details
buildbot/monero-gui-ubuntu-amd64 Build done.
Details
buildbot/monero-gui-ubuntu-i686 Build done.
Details
buildbot/monero-gui-win32 Build done.
Details

luigi1111 added a commit that referenced this pull request May 7, 2018

Merge pull request #1359
5a1952f Reordered QR/Tracking sections on the receive page
44ad8a3 Redesigned the tracking section
cb94523 This doesnt belong here
6ff273f First iteration of the subaddress table restyle
0e49e4a Reimplemented create/edit/copy (sub)address icons and buttons
5487383 Variable address truncation (for mobile)
9018ae3 Dynamic page height for the receive page
dc1d5e9 Check the 'to receive amount' with the transaction tracker
229fba2 Introduced 'show advanced options' checkbox
d6427a1 Fixes undefined references to 'bg', was previously moved to main.inactiveOverlay
1541d87 Fixes undefined reference to 's'
178be38 Cursor pointer on link hover for richtexts
bfbe00e Removed obsolete SubaddressTable.qml component
3e5f5f3 Adding editIcon.png
bff2701 Fixes the background for 2 popups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.