New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock wallet on inactivity #1814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Nice attention with the 1 minute vs >1 minutes 👍
pages/settings/SettingsLayout.qml
Outdated
value: persistentSettings.lockOnUserInActivityInterval | ||
to: 60 | ||
leftPadding: 0 | ||
stepSize: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for stepSize 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to 1
pages/settings/SettingsLayout.qml
Outdated
var val = userInactivitySlider.value; | ||
var minutes = val > 1 ? qsTr("minutes") : qsTr("minute"); | ||
|
||
qsTr("After ") + userInactivitySlider.value + " " + minutes + translationManager.emptyString; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use val
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Please squash
|
@xiphon no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first commit User activity signal
is not self-consistent.
It contains a error: it invokes non-existing userActivity
signal handler.
There will be a warning printed in the console.
@xiphon rebased & squashed |
I think everyone would prefer it if you squash all commits together but if you insist on keeping it like this (it’s your PR after all), I guess we can merge this. |
main.qml
Outdated
@@ -1817,12 +1830,39 @@ ApplicationWindow { | |||
} | |||
} | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Squashed all. |
pages/settings/SettingsLayout.qml
Outdated
Rectangle { | ||
width: parent.visualPosition * parent.width | ||
height: parent.height | ||
color: "#21be2b" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
color: "#21be2b" | |
color: MoneroComponents.Style.green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
5bebf83 Lock wallet on inactivity (xmrdsc)
Fixes #814
lockOnUserInActivity
(bool) andlockOnUserInActivityInterval
(minutes)