Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive: update subaddress table design #1914

Merged
merged 1 commit into from Feb 6, 2019

Conversation

selsta
Copy link
Collaborator

@selsta selsta commented Jan 22, 2019

Same design as in #1905. Not sure if the item height is too high now, I’ve used the same design as the address book table from zeplin.io

screenshot 2019-01-22 at 15 51 19

@dEBRUYNE-1
Copy link
Contributor

As a side note, perhaps the orange buttons below the QR code should be centered?

@mmbyday
Copy link
Contributor

mmbyday commented Jan 22, 2019

@dEBRUYNE-1 done in #1915 :)

@selsta Looks good for design consistency. Agree with item height which could be lower. Too much white/black space per row.

@GBKS
Copy link
Contributor

GBKS commented Jan 28, 2019

monero-expandable-addresses-gbks-190128

How about using expandable rows like we do in the transactions screen? The problem I see with the static detail display as shown in the GIF in #1915 is that it gets pushed down if you have a lot of addresses. With expandable rows, you avoid this.

@SamsungGalaxyPlayer
Copy link

@GBKS that's one way to handle it. Another option is to simply only scroll the subaddresses, not the QR code too. So the top scrollbar would allow you to go through the different subaddresses while the QR code stayed in the same place.

I have no particular opinion on which is better, I'll leave it up to the great UX team :)

@GBKS
Copy link
Contributor

GBKS commented Jan 29, 2019

@SamsungGalaxyPlayer we also had a chat about this on IRC yesterday. @xmrdsc pointed out we already do what you mention on the Receive screen.

I find it a bit cluttered, but both approaches should work well on desktop. If the wallet needs to work on mobile, we might have to adjust in one way or another since we'll be very tight space-wise. But we can probably cross that bridge when we get to it.

@luigi1111 luigi1111 merged commit 28332f5 into monero-project:master Feb 6, 2019
luigi1111 added a commit that referenced this pull request Feb 6, 2019
28332f5 Receive: update subaddress table design (selsta)
@selsta selsta deleted the receive-table branch February 8, 2019 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants