Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddressBook: redesign #2055

Merged
merged 1 commit into from Apr 8, 2019

Conversation

Projects
None yet
4 participants
@selsta
Copy link
Contributor

commented Apr 5, 2019

Basically exactly @GBKS design.

Screenshot 2019-04-05 at 19 51 30

Known bugs: If there is no address book entry, the headline wraps into the text below.

@mmbyday

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

Very nice. I like the changes @selsta

A few quick observations

  • delete an address book entry not yet working
  • edit an address book entry creates an additional new entry
  • spacing looks a little tight.
    spacing
@selsta

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

@mmbyday Deleting and editing works fine on my system. (macOS)

What Qt version are you using?

@mmbyday

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

@selsta 5.11.1, which was the last known working QT version on Windows. Tried QT 5.7 on Windows in the past but no such luck.

@selsta

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

Note that editing uses a hack (deletes the selected entry + adds a new one with edited information) because there is no edit address book API function. The delete function uses only the API and should work without any problems.

@selsta

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

I can reproduce the issue with entries not getting deleted when using the buildbot build.

Weird, I can’t consistently reproduce it.

@selsta selsta force-pushed the selsta:addressbook-menu branch 2 times, most recently from 894ad89 to 8c256f4 Apr 6, 2019

@selsta

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2019

Editing and deleting is now working, also improved the spacing.

@selsta selsta force-pushed the selsta:addressbook-menu branch from 8c256f4 to 5b3d282 Apr 7, 2019

@xmrdsc

This comment has been minimized.

Copy link
Contributor

commented Apr 7, 2019

Working great 👍

@xmrdsc

xmrdsc approved these changes Apr 7, 2019

@selsta selsta force-pushed the selsta:addressbook-menu branch from 5b3d282 to db49e9b Apr 7, 2019

@luigi1111

This comment has been minimized.

Copy link
Collaborator

commented Apr 8, 2019

@selsta please rebase.

@selsta selsta force-pushed the selsta:addressbook-menu branch from db49e9b to 1e6e928 Apr 8, 2019

@luigi1111 luigi1111 merged commit 1e6e928 into monero-project:master Apr 8, 2019

luigi1111 added a commit that referenced this pull request Apr 8, 2019

Merge pull request #2055
1e6e928 AddressBook: redesign (selsta)

@selsta selsta deleted the selsta:addressbook-menu branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.