Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer: fix offline signing #3862

Merged
merged 1 commit into from Mar 18, 2022
Merged

Transfer: fix offline signing #3862

merged 1 commit into from Mar 18, 2022

Conversation

reemuru
Copy link
Contributor

@reemuru reemuru commented Mar 15, 2022 •
edited

Closes #3861

@reemuru reemuru mentioned this pull request Mar 15, 2022
Closed
@reemuru reemuru marked this pull request as ready for review March 16, 2022 11:18
@reemuru
Transfer: fix offline signing
8bbf2bf 
Remove logic for processing an array to derive the confirmation.
Use confirmation from the transaction object.
@luigi1111 luigi1111 merged commit 1dba06a into monero-project:master Mar 18, 2022
@reemuru reemuru mentioned this pull request May 5, 2022
Closed
@reemuru reemuru deleted the offline-sign branch June 27, 2022 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selsta selsta selsta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offline transaction signing: Unknown method parameter type: size_t
3 participants
@reemuru @selsta @luigi1111