New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightwallet support + mobile redesign (no merge) #780

Closed
wants to merge 31 commits into
base: master
from

Conversation

Projects
None yet
@Jaqueeee
Contributor

Jaqueeee commented Jun 23, 2017

requires #2109

  • Lightwallet support (mymonero/openmonero)
  • reworked layout for smaller screens.
  • Better remote node integration. Option to use remote node while syncing local node
  • Restore/export wallet with QR code
  • Moved seed&Keys to own tab.
  • other small changes and improvements

Some cleanup and optimisations is needed before this can be merged. PR'ing to get feedback from testers.

Experimental Android build
https://www.dropbox.com/s/cv3ey6h93xlq4z9/monero-wallet-gui.apk?dl=0
Tested on Xiaomi Redmi 4. My goal is to make the interface as dynamic as possible. Would love to get feedback on how it looks on other screens.
NOTE: this is not an official build. (Don't trust it)
If you want to build yourself I recommend these instructions from @MoroccanMalinois
https://github.com/MoroccanMalinois/monero-core/tree/android_dockerfile/android

Known issues

Android

  • Selections handles can get stuck on screen after selecting text
  • Translations doesn't work yet
  • Crash when using backbutton

IOS

  • QR-code scanner not implemented yet

Edit: new APK link

Jaqueeee added some commits Mar 24, 2017

Remote node settings
add remoteNodeDropdown

Wizard: add daemon settings page

Remote node integration

add WalletManager::localDaemonSynced()

replace remote node dropdown with empty input field

add advanced daemon settings checkbox + redesign

DaemonManager: support dataDir parameter + validator

Setttings: blockchain folder location

Add blockchain folder settings to wizard

rename remoteNodeDropDown->remoteNodeEdit

ux improvements

add remoteNodeDropdown

Remote node integration

add WalletManager::localDaemonSynced()

replace remote node dropdown with empty input field

add advanced daemon settings checkbox + redesign

Setttings: blockchain folder location

Add blockchain folder settings to wizard

rename remoteNodeDropDown->remoteNodeEdit

ux improvements

resolved merge conflicts

reenable switch to remote node
LightWallets
openmonero initial commit

more android fixes

QrCodeScanner: Added extra parameters

mobile adjustments

disable title bar on mobile view

mobile layout - progressbar + networkstatus

add lightwallet as network status

Add functions for switching between full and light wallet

StandardDropdown: add onChanged handler
Export/import wallets with QR-code
implemented getRestoreHeight()

Added seed & keys tab/page

remove 'show keys' button

remove spendable qr-code on viewOnly wallet

keys page: remove secret spend key on view only wallet

lightwallet fixes

close wallet when swithing mode

code cleanup

prevet wallet from crashing on exit (dropdown model)
update ios build script + instructions
android/ios build settings

updated .gitignore
LightWallet adjustments
requires #2109
@mrowwy

This comment has been minimized.

Show comment
Hide comment
@mrowwy

mrowwy Jun 23, 2017

Password managers like LastPass do not detect/recognize the password field for "auto-fill". I'm am unsure exactly what would need to change to make them compatible.

mrowwy commented Jun 23, 2017

Password managers like LastPass do not detect/recognize the password field for "auto-fill". I'm am unsure exactly what would need to change to make them compatible.

@Jaqueeee

This comment has been minimized.

Show comment
Hide comment
@Jaqueeee

Jaqueeee Jun 24, 2017

Contributor

Update 170625

Contributor

Jaqueeee commented Jun 24, 2017

Update 170625

@unknownids

This comment has been minimized.

Show comment
Hide comment
@unknownids

unknownids Jun 24, 2017

thanks for the work Jaqueeee :D

Heres some screens from the latest build (I assume you updated the dropbox link?) Anyway this is for the S6 Edge http://imgur.com/a/aIMIO

some comments

crash: clicked QR code button, successfully opened camera, click the back arrow (on my s6 edge) to close the camera and get back into app and it crashed.
reproducable?: yes

crash: monero at default send screen after logging in, hitting the back arrow on the s6 edge to get back to the android desktop crashes the app
reproducable?: yes

at the menu selection dragging the menu down and letting it bounce back up removes the yellow icon at the top left (see screenshots)
reproducable: yes

keep up the good work

EDIT:

first one (back arrow crash from send screen) : https://pastebin.com/NiqEn1XZ second one (crash exiting qr code): https://pastebin.com/S26F2HsT

unknownids commented Jun 24, 2017

thanks for the work Jaqueeee :D

Heres some screens from the latest build (I assume you updated the dropbox link?) Anyway this is for the S6 Edge http://imgur.com/a/aIMIO

some comments

crash: clicked QR code button, successfully opened camera, click the back arrow (on my s6 edge) to close the camera and get back into app and it crashed.
reproducable?: yes

crash: monero at default send screen after logging in, hitting the back arrow on the s6 edge to get back to the android desktop crashes the app
reproducable?: yes

at the menu selection dragging the menu down and letting it bounce back up removes the yellow icon at the top left (see screenshots)
reproducable: yes

keep up the good work

EDIT:

first one (back arrow crash from send screen) : https://pastebin.com/NiqEn1XZ second one (crash exiting qr code): https://pastebin.com/S26F2HsT

@MoroccanMalinois

overall, impressive work 🥇
I can confirm @unknownids crash (with the provided apk). It happens anywhere in the app, as long it hits the back arrow and there is no keyboard to remove.

return m_currentWallet->parse_uri(uri, address, payment_id, amount, tx_description, recipient_name, unknown_parameters, error);
if (m_currentWallet) {
m_currentWallet->parse_uri(uri, address, payment_id, amount, tx_description, recipient_name, unknown_parameters, error);
return true;

This comment has been minimized.

@MoroccanMalinois

MoroccanMalinois Jun 25, 2017

Contributor

always true ?

@MoroccanMalinois

MoroccanMalinois Jun 25, 2017

Contributor

always true ?

@SamsungGalaxyPlayer

This comment has been minimized.

Show comment
Hide comment
@SamsungGalaxyPlayer

SamsungGalaxyPlayer Jun 25, 2017

More screenshots from an OPO. Very similar to @unknownids S6 Edge: http://imgur.com/a/qV9hg

I replicated the back button crash. Hitting the back button at any time without the keyboard open crashes the application.

SamsungGalaxyPlayer commented Jun 25, 2017

More screenshots from an OPO. Very similar to @unknownids S6 Edge: http://imgur.com/a/qV9hg

I replicated the back button crash. Hitting the back button at any time without the keyboard open crashes the application.

@Jaqueeee

This comment has been minimized.

Show comment
Hide comment
@Jaqueeee

Jaqueeee Jun 25, 2017

Contributor

apk updated again.

  • Fixed back button crash
  • hide verify/sign on mobiles
  • small redesign on transfer page

ping @SamsungGalaxyPlayer @medusadigital @unknownids @mrowwy @MoroccanMalinois

Contributor

Jaqueeee commented Jun 25, 2017

apk updated again.

  • Fixed back button crash
  • hide verify/sign on mobiles
  • small redesign on transfer page

ping @SamsungGalaxyPlayer @medusadigital @unknownids @mrowwy @MoroccanMalinois

@nixuxmr

This comment has been minimized.

Show comment
Hide comment
@nixuxmr

nixuxmr Jun 26, 2017

Looking that great on an OP2 too, thanks for this @Jaqueeee !
Can confirm, the back button crash is fixed also when returning from QR scan (updated apk).

nixuxmr commented Jun 26, 2017

Looking that great on an OP2 too, thanks for this @Jaqueeee !
Can confirm, the back button crash is fixed also when returning from QR scan (updated apk).

@SamsungGalaxyPlayer

This comment has been minimized.

Show comment
Hide comment
@SamsungGalaxyPlayer

SamsungGalaxyPlayer commented Jun 26, 2017

@Jaqueeee back button works now (see images) https://imgur.com/a/8YmRi

@oakey22

This comment has been minimized.

Show comment
Hide comment
@oakey22

oakey22 Jun 26, 2017

When selecting the fee for a send transaction, you are unable to select the 1x fee once you select something else.

oakey22 commented Jun 26, 2017

When selecting the fee for a send transaction, you are unable to select the 1x fee once you select something else.

Jaqueeee added some commits Jun 28, 2017

fix crash on exit Qt 5.8
requires #2109
@amiuhle

This comment has been minimized.

Show comment
Hide comment
@amiuhle

amiuhle Jun 29, 2017

Contributor

QR Code scanning for an address works, but when it has an added amount, it doesn't get parsed correctly.

Example: monero:A3Brqw9sVmwLyWS8EWeUw1VqpqfwnDHTkG7Pb4NJ3RmZWeeMZhGMe2ZXz4bSk7BbtEYF5981nLxkDYQ6B46tX5DMVoPGjfBxi6tLZwHK6E?tx_amount=0.6380155748871774

Edit: Sorry, my bad - the amount isn't correctly formatted.

Contributor

amiuhle commented Jun 29, 2017

QR Code scanning for an address works, but when it has an added amount, it doesn't get parsed correctly.

Example: monero:A3Brqw9sVmwLyWS8EWeUw1VqpqfwnDHTkG7Pb4NJ3RmZWeeMZhGMe2ZXz4bSk7BbtEYF5981nLxkDYQ6B46tX5DMVoPGjfBxi6tLZwHK6E?tx_amount=0.6380155748871774

Edit: Sorry, my bad - the amount isn't correctly formatted.

@amiuhle

This comment has been minimized.

Show comment
Hide comment
@amiuhle

amiuhle Jun 29, 2017

Contributor

When scanning the QR Code, the camera image is flipped:

Edit: Nexus 5X with Android 7.1.2 (vanilla, unrooted).

screenshot_20170629-210004

Contributor

amiuhle commented Jun 29, 2017

When scanning the QR Code, the camera image is flipped:

Edit: Nexus 5X with Android 7.1.2 (vanilla, unrooted).

screenshot_20170629-210004

@snaggen

This comment has been minimized.

Show comment
Hide comment
@snaggen

snaggen Jun 29, 2017

Contributor

The 5X have the sensor flipped, so it requires applications to use the newer camera apis. Not sure exactly which api but there was a lot noise about this when the 5x came out, so it should be easy to google.

Contributor

snaggen commented Jun 29, 2017

The 5X have the sensor flipped, so it requires applications to use the newer camera apis. Not sure exactly which api but there was a lot noise about this when the 5x came out, so it should be easy to google.

@mrowwy

This comment has been minimized.

Show comment
Hide comment
@mrowwy

mrowwy Jun 29, 2017

-Text cutoff at bottom of seed indicating which wallet type is selected.
-Button coloring for selection state in settings is not intuitive to me. It seems like the more vibrant one should be selected.
-3-bar icon ( top-left ) disappears when in sidebar
-text cutoff during wallet creation process
-sometimes cannot paste password when in app. I have to leave the app and come back to see the paste option ( would be nice if LastPass could detect ;) )

http://imgur.com/a/H1nyH ( select show 3 more images to see all from mobile )

mrowwy commented Jun 29, 2017

-Text cutoff at bottom of seed indicating which wallet type is selected.
-Button coloring for selection state in settings is not intuitive to me. It seems like the more vibrant one should be selected.
-3-bar icon ( top-left ) disappears when in sidebar
-text cutoff during wallet creation process
-sometimes cannot paste password when in app. I have to leave the app and come back to see the paste option ( would be nice if LastPass could detect ;) )

http://imgur.com/a/H1nyH ( select show 3 more images to see all from mobile )

@jonathancross

This comment has been minimized.

Show comment
Hide comment
@jonathancross

jonathancross Jul 2, 2017

Contributor

@amiuhle The "paid" Barcode Scanner+ Simple fixed the flipped screen for me on Nexus 5x with Mycelium, so will probably work here as well. The app is Open Source, needs minimal permissions and the $1 you pay goes to WWF / Rainforest Alliance.

Contributor

jonathancross commented Jul 2, 2017

@amiuhle The "paid" Barcode Scanner+ Simple fixed the flipped screen for me on Nexus 5x with Mycelium, so will probably work here as well. The app is Open Source, needs minimal permissions and the $1 you pay goes to WWF / Rainforest Alliance.

@ReilySiegel

This comment has been minimized.

Show comment
Hide comment
@ReilySiegel

ReilySiegel Jul 7, 2017

Transaction will not send: Transaction cannot pay for itself.

This occurs when trying to send all XMR in a wallet (0.01 XMR) at x1 fees. When imported into the desktop GUI, the transaction sends fine.

Amount: 0.006327110000
Fee: 0.003672890000

Ringsize: 5
Number of transactions: 1

ReilySiegel commented Jul 7, 2017

Transaction will not send: Transaction cannot pay for itself.

This occurs when trying to send all XMR in a wallet (0.01 XMR) at x1 fees. When imported into the desktop GUI, the transaction sends fine.

Amount: 0.006327110000
Fee: 0.003672890000

Ringsize: 5
Number of transactions: 1
@grigio

This comment has been minimized.

Show comment
Hide comment
@grigio

grigio Jul 7, 2017

Contributor

Hi this is my feedback, i see very little label specially in the settings screen and I think the "audio recording permission" isn't needed

Contributor

grigio commented Jul 7, 2017

Hi this is my feedback, i see very little label specially in the settings screen and I think the "audio recording permission" isn't needed

@Jaqueeee

This comment has been minimized.

Show comment
Hide comment
@Jaqueeee

Jaqueeee Oct 27, 2017

Contributor

Closing in favor of #826

Contributor

Jaqueeee commented Oct 27, 2017

Closing in favor of #826

@Jaqueeee Jaqueeee closed this Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment