New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta tags: Change opengraph logo and add possiblity to use custom one #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erciccione
force-pushed
the
meta-logo
branch
2 times, most recently
from
May 24, 2020 11:18
21eabef
to
91247bf
Compare
Changed |
Deploy preview for zen-roentgen-73fc0e ready! Built with commit 18bedd3 https://deploy-preview-1002--zen-roentgen-73fc0e.netlify.app |
erciccione
added a commit
to erciccione/monero-site
that referenced
this pull request
Jun 22, 2020
- Use 'jekyll-feed' plugin to manage RSS feed and remove existing feed.xml file - Add feed image in main blog tab ('All posts') The 'jekyll-feed' plugin makes possible for aggregators to automatically detect the existence of a feed (feed_meta tag in header) and creates a 'feed.atom' file containing the last 20 blog posts and locates it in the root directory. The structure is compatible with our current system, including the possibility to show a picture if it's included in the post (monero-project#1002).
erciccione
added a commit
to erciccione/monero-site
that referenced
this pull request
Jun 22, 2020
- Use 'jekyll-feed' plugin to manage RSS feed and remove existing feed.xml file - Add feed image in main blog tab ('All posts') The 'jekyll-feed' plugin makes possible for aggregators to automatically detect the existence of a feed (feed_meta tag in header) and creates a 'feed.atom' file containing the last 20 blog posts and locates it in the root directory. The structure is compatible with our current system, including the possibility to show a picture if it's included in the post (monero-project#1002).
selsta
approved these changes
Jun 24, 2020
SamsungGalaxyPlayer
suggested changes
Jun 24, 2020
The old logo showing on social medias is too large and end up being trimmed. Replaced it with the simple Monero Logo. If an image is specified using 'image:' in the front matter of a blog post, jekyll will show that image instead. This also allow us to easily make specific meta-images for each blog posts. I will add the possibility to add the image in the body of the post in a subsequent PR.
selsta
approved these changes
Jun 24, 2020
erciccione
added a commit
to erciccione/monero-site
that referenced
this pull request
Jul 29, 2020
- Use 'jekyll-feed' plugin to manage RSS feed and remove existing feed.xml file - Add feed image in main blog tab ('All posts') The 'jekyll-feed' plugin makes possible for aggregators to automatically detect the existence of a feed (feed_meta tag in header) and creates a 'feed.atom' file containing the last 20 blog posts and locates it in the root directory. The structure is compatible with our current system, including the possibility to show a picture if it's included in the post (monero-project#1002).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old logo showing on social medias is too large and end up being trimmed:
Twitter:
Reddit:
Replaced it with the simple Monero Logo. If a logo is specified using 'image:' in the front matter, jekyll will show this one instead. This also allow us to easily make specific meta-images for each blog post. I will add the possibility to add the image in the body of the post in a subsequent PR.