Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ: add Monero videos ("Are there videos I can watch to learn about Monero?") #1304

Merged
merged 2 commits into from Dec 14, 2020

Conversation

erciccione
Copy link
Contributor

@erciccione erciccione commented Nov 12, 2020

Based on #1291

This PR is a follow up of #1190, as i suggest in the description:

If we like this change, i suggest to also create a FAQ entry saying something like "Are there some videos about how Monero works?" and then link to the videos.

Pushing as draft because i want to check the preview on various browsers before opening it for reviews. Chrome and Chromium seem to attempt to download the videos when we click on the links, but apparently this is caused by local configurations. (Update: it is caused by a local configuration. The videos are shown correctly on chromium and Chrome on an Ubuntu VM. I'm opening this PR for reviews)

@netlify
Copy link

netlify bot commented Nov 12, 2020

Deploy preview for barolo-time-757cf9 ready!

Built with commit 411b5bc

https://deploy-preview-1304--barolo-time-757cf9.netlify.app

@erciccione erciccione marked this pull request as ready for review November 12, 2020 13:15
new entry: "Are there videos I can watch to learn about Monero?"
@SamsungGalaxyPlayer
Copy link
Contributor

image

The initial R in RingCT isn't capitalized for some reason.

I approve of everything else :)

@erciccione
Copy link
Contributor Author

@SamsungGalaxyPlayer That's unrelated to this PR and probably happens somewhere else. The script that create the Moneopedia links doesn't understand capitalization, so the link is always lower case.

Copy link
Contributor

@SamsungGalaxyPlayer SamsungGalaxyPlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth addressing that bug if possible since it does look unattractive, but I approve of this PR if it needs to be addressed elsewhere.

@erciccione
Copy link
Contributor Author

Opened #1352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants