Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional unlock_time details to Moneropedia #1343

Closed
wants to merge 3 commits into from
Closed

Add additional unlock_time details to Moneropedia #1343

wants to merge 3 commits into from

Conversation

SamsungGalaxyPlayer
Copy link
Contributor

Requires a review by a knowledgeable individual, such as @TheCharlatan or @Mitchellpkt.

Requires a review by a knowledgeable individual, such as TheCharlatan or Isthmus.
@netlify
Copy link

netlify bot commented Nov 28, 2020

Deploy preview for barolo-time-757cf9 ready!

Built without sensitive environment variables with commit 8a6d6f9

https://deploy-preview-1343--barolo-time-757cf9.netlify.app

Copy link

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. I just have a suggestion for additional content.

_i18n/en/resources/moneropedia/unlocktime.md Outdated Show resolved Hide resolved
@Mitchellpkt
Copy link
Contributor

Mitchellpkt commented Nov 29, 2020

Good updates, thanks for writing this up sgp.

Hmm, I'm not sure if this is in scope of the doc, but I'll mention it just in case - there is a mismatch between CLI & RPC behavior around transaction generation. If I recall correctly, the wallet only accepts height-like values (up to millions), but the RPC accepts any uint64 value (up to 18,446,744,073,709,551,615). Thus transactions with very high lock values were either submitted by RPC or custom software. (Also, I'm not sure, does the GUI set unlock_time=0 for all transactions it creates, or is there a way to customize it?)

@Mitchellpkt
Copy link
Contributor

Oh, and also potential wording tweak, clarify
"The integer should be an absolute block height value or Unix epoch timestamp, not a relative value"
to
"The integer value will be interpreted by the protocol as an absolute block height value or Unix epoch timestamp, not a relative value"

@SamsungGalaxyPlayer
Copy link
Contributor Author

@Mitchellpkt @TheCharlatan please review when you have a chance

@erciccione
Copy link
Contributor

Let's wait a bit before merging this. #1270 must be kept in consideration.

@erciccione erciccione added this to Review Needed in monero-site: PR workflow Oct 12, 2021
@erciccione erciccione moved this from Review Needed to Ready for merge in monero-site: PR workflow Oct 12, 2021
@erciccione erciccione moved this from Ready for merge to Draft in monero-site: PR workflow Oct 12, 2021
@plowsof
Copy link
Contributor

plowsof commented Jan 3, 2023

closed by #2076

luigi1111 added a commit that referenced this pull request Jan 11, 2023
#1343 moneropedia update unlocktime
monero-site: PR workflow automation moved this from Draft to Done Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants