New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional unlock_time details to Moneropedia #1343
Add additional unlock_time details to Moneropedia #1343
Conversation
Requires a review by a knowledgeable individual, such as TheCharlatan or Isthmus.
Deploy preview for barolo-time-757cf9 ready! Built without sensitive environment variables with commit 8a6d6f9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. I just have a suggestion for additional content.
Good updates, thanks for writing this up sgp. Hmm, I'm not sure if this is in scope of the doc, but I'll mention it just in case - there is a mismatch between CLI & RPC behavior around transaction generation. If I recall correctly, the wallet only accepts height-like values (up to millions), but the RPC accepts any uint64 value (up to 18,446,744,073,709,551,615). Thus transactions with very high lock values were either submitted by RPC or custom software. (Also, I'm not sure, does the GUI set |
Oh, and also potential wording tweak, clarify |
Adjusted based on your comments @TheCharlatan or @Mitchellpkt
@Mitchellpkt @TheCharlatan please review when you have a chance |
Let's wait a bit before merging this. #1270 must be kept in consideration. |
closed by #2076 |
#1343 moneropedia update unlocktime
Requires a review by a knowledgeable individual, such as @TheCharlatan or @Mitchellpkt.