Skip to content
Permalink
Browse files

cryptonote_basic: drop unused verification_context::m_not_rct field

  • Loading branch information
xiphon committed Jan 9, 2020
1 parent 3c01bff commit a28aad09b5cb20b5021b91f6bff5b632407fff1f
@@ -47,7 +47,6 @@ namespace cryptonote
bool m_too_big;
bool m_overspend;
bool m_fee_too_low;
bool m_not_rct;
bool m_too_few_outputs;
};

@@ -1115,8 +1115,6 @@ namespace cryptonote
add_reason(reason, "overspend");
if ((res.fee_too_low = tvc.m_fee_too_low))
add_reason(reason, "fee too low");
if ((res.not_rct = tvc.m_not_rct))
add_reason(reason, "tx is not ringct");
if ((res.too_few_outputs = tvc.m_too_few_outputs))
add_reason(reason, "too few outputs");
const std::string punctuation = reason.empty() ? "" : ": ";
@@ -88,7 +88,7 @@ namespace cryptonote
// advance which version they will stop working with
// Don't go over 32767 for any of these
#define CORE_RPC_VERSION_MAJOR 3
#define CORE_RPC_VERSION_MINOR 0
#define CORE_RPC_VERSION_MINOR 1
#define MAKE_CORE_RPC_VERSION(major,minor) (((major)<<16)|(minor))
#define CORE_RPC_VERSION MAKE_CORE_RPC_VERSION(CORE_RPC_VERSION_MAJOR, CORE_RPC_VERSION_MINOR)

@@ -586,7 +586,6 @@ namespace cryptonote
bool too_big;
bool overspend;
bool fee_too_low;
bool not_rct;
bool too_few_outputs;
bool sanity_check_failed;

@@ -601,7 +600,6 @@ namespace cryptonote
KV_SERIALIZE(too_big)
KV_SERIALIZE(overspend)
KV_SERIALIZE(fee_too_low)
KV_SERIALIZE(not_rct)
KV_SERIALIZE(too_few_outputs)
KV_SERIALIZE(sanity_check_failed)
END_KV_SERIALIZE_MAP()
@@ -338,11 +338,6 @@ namespace rpc
if (!res.error_details.empty()) res.error_details += " and ";
res.error_details = "fee too low";
}
if (tvc.m_not_rct)
{
if (!res.error_details.empty()) res.error_details += " and ";
res.error_details = "tx is not ringct";
}
if (tvc.m_too_few_outputs)
{
if (!res.error_details.empty()) res.error_details += " and ";
@@ -236,8 +236,6 @@ namespace
add_reason(reason, "overspend");
if (res.fee_too_low)
add_reason(reason, "fee too low");
if (res.not_rct)
add_reason(reason, "tx is not ringct");
if (res.sanity_check_failed)
add_reason(reason, "tx sanity check failed");
if (res.not_relayed)
@@ -256,7 +256,6 @@ def transfer(self):
assert res.too_big == False
assert res.overspend == False
assert res.fee_too_low == False
assert res.not_rct == False

self.wallet[0].refresh()

@@ -598,7 +597,6 @@ def check_double_spend_detection(self):
assert res.too_big == False
assert res.overspend == False
assert res.fee_too_low == False
assert res.not_rct == False

res = daemon.get_transactions([txes[0][0]])
assert len(res.txs) >= 1
@@ -615,7 +613,6 @@ def check_double_spend_detection(self):
assert res.too_big == False
assert res.overspend == False
assert res.fee_too_low == False
assert res.not_rct == False
assert res.too_few_outputs == False

res = daemon.get_transactions([txes[0][0]])

0 comments on commit a28aad0

Please sign in to comment.
You can’t perform that action at this time.