Skip to content

Updates#1744

Merged
fluffypony merged 10 commits into
monero-project:masterfrom
moneromooo-monero:updates
Feb 21, 2017
Merged

Updates#1744
fluffypony merged 10 commits into
monero-project:masterfrom
moneromooo-monero:updates

Conversation

@moneromooo-monero

Copy link
Copy Markdown
Collaborator

No description provided.

@moneromooo-monero

Copy link
Copy Markdown
Collaborator Author

DO NOT MERGE YET

@moneromooo-monero

Copy link
Copy Markdown
Collaborator Author

Aaaaaand I uploaded an old version. Fixing...

@moneromooo-monero

Copy link
Copy Markdown
Collaborator Author

STILL DO NOT MERGE YET

@ghost

ghost commented Feb 18, 2017

Copy link
Copy Markdown

So there's an interesting philosophical point here - we use an adversarial system to achieve consensus on the network's transaction record system (the blockchain) to prevent censorship. Yet here a three letter agency need only attack the single source of software updates to gain control.

Is there a way we can safely distribute or validate the correctness of our software in a censorship resistant manner?

@moneromooo-monero

Copy link
Copy Markdown
Collaborator Author

It already does. pigeons will work on reproducible builds. As for the rest, we'd need to make sure it's hard to sybil. This all sounds a bit like "wouldn't it be nice if we all had flying cars". Sure, but you might notice the reason it's not there yet isn't that nobody realized it was a good idea (and I'm not sure about the flying cars one).

So, maybe, but not now.

@moneromooo-monero

moneromooo-monero commented Feb 19, 2017

Copy link
Copy Markdown
Collaborator Author

Update to match URLs being less canonical than I'd want them.

STILL DO NOT MERGE Can be merged now.

@moneromooo-monero
moneromooo-monero force-pushed the updates branch 2 times, most recently from d06becb to 395a4f4 Compare February 20, 2017 21:57

@fluffypony fluffypony left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@fluffypony fluffypony left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed

@fluffypony
fluffypony merged commit a5a0a3c into monero-project:master Feb 21, 2017
fluffypony added a commit that referenced this pull request Feb 21, 2017
a5a0a3c core: updates can now be downloaded (and SHA256 hash checked) (moneromooo-monero)
216f062 util: add a SHA256 function (moneromooo-monero)
4bf7849 mlog: only silence errors for net by default, not net.* (moneromooo-monero)
d282cfc core: test key images against validity domain (moneromooo-monero)
efb72e7 http_client: add a couple consts (moneromooo-monero)
f640512 Optionally query moneropulse DNS records to check for updates (moneromooo-monero)
e3cae4a core: display any fork warning at startup too (moneromooo-monero)
969ad71 dns_utils: fix first checked DNS entry being ignored (moneromooo-monero)
08c3f38 util: add a vercmp function to compare version numbers (moneromooo-monero)
e8a7525 dns_utils: factor TXT record loading code from checkpoint code (moneromooo-monero)
@fluffypony

Copy link
Copy Markdown
Contributor

@NanoAkron they don't need to just compromise the website. They'd also have to compromise the hashes, which are GPG signed by me (on the website) and also in a DNSSEC-signed record (which is what the updater uses). Compromising my GPG key wouldn't compromise the website or the DNSSEC-signed record. Compromising the DNSSEC-signed record wouldn't compromise the website or my GPG key.

It would be nice if someone built a tool / hosted a site (eventually) that checked if the GPG-signed hashes correctly use my signature, and if the hashes match those in the DNSSEC-signed records.

for(const auto& in: tx.vin)
{
CHECKED_GET_SPECIFIC_VARIANT(in, const txin_to_key, tokey_in, false);
if (!(rct::scalarmultKey(rct::ki2rct(tokey_in.k_image), rct::curveOrder()) == rct::identity()))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iridiumblue

Copy link
Copy Markdown

Wow - this is what a billion-dollar act of integrity looks like.

Respect.

@nfd9001

nfd9001 commented May 24, 2017

Copy link
Copy Markdown

Badass! Thanks.

@stefek99

stefek99 commented Jun 6, 2017

Copy link
Copy Markdown

I do not fully understand the mechanism and / or implications.

Arrived here via blog some time ago: https://getmonero.org/2017/05/17/disclosure-of-a-major-bug-in-cryptonote-based-currencies.html

Now I'm looking at https://cryptonotestarter.org/inner.html and https://github.com/cryptonotefoundation/cryptonote

Latest commit 8edd998 on Jan 18, 2016

I should probably notify them and request update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants