New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoS/RPC fixes #4438

Merged
merged 3 commits into from Sep 25, 2018

Conversation

3 participants
@moneromooo-monero
Contributor

moneromooo-monero commented Sep 25, 2018

No description provided.

moneromooo-monero added some commits Aug 2, 2018

epee: fix invalid memory write reading an array entry
Reported by Lilith Wyatt at Talos.

Since this is not needed in normal operation, I just let this
error out.
@fluffypony

Reviewed

@moneromooo-monero moneromooo-monero changed the title from Bm to DoS/RPC fixes Sep 25, 2018

@fluffypony fluffypony merged commit e350cc5 into monero-project:master Sep 25, 2018

fluffypony added a commit that referenced this pull request Sep 25, 2018

Merge pull request #4438
e350cc5 wallet2: fix duplicate output making it to the RPC (moneromooo-monero)
bf9a0f4 epee: fix stack overflow on crafted input (moneromooo-monero)
45683ee epee: fix invalid memory write reading an array entry (moneromooo-monero)

neuroscr pushed a commit to neuroscr/loki that referenced this pull request Sep 25, 2018

Merge pull request monero-project#4438
e350cc5 wallet2: fix duplicate output making it to the RPC (moneromooo-monero)
bf9a0f4 epee: fix stack overflow on crafted input (moneromooo-monero)
45683ee epee: fix invalid memory write reading an array entry (moneromooo-monero)

thaerkh added a commit to masari-project/masari that referenced this pull request Sep 25, 2018

@thaerkh thaerkh referenced this pull request Sep 25, 2018

Merged

DoS/RPC fixes #103

@psychocrypt

This comment has been minimized.

Show comment
Hide comment
@psychocrypt

psychocrypt Sep 25, 2018

It would be nice if you can link https://getmonero.org/2018/09/25/a-post-mortum-of-the-burning-bug.html in the PR description. Due to missing descriptions and labeling it is nearly impossible to follow the Monero code development.

psychocrypt commented Sep 25, 2018

It would be nice if you can link https://getmonero.org/2018/09/25/a-post-mortum-of-the-burning-bug.html in the PR description. Due to missing descriptions and labeling it is nearly impossible to follow the Monero code development.

sumoprojects added a commit to sumoprojects/sumokoin that referenced this pull request Sep 26, 2018

Fix critical Monero burning bug
Merge from monero-project/monero#4438

More info: https://getmonero.org/2018/09/25/a-post-mortum-of-the-burning-bug.html

Note: file "contrib/epee/include/storages/portable_storage_from_json.h" was already patched from code base v0.12.3.0

RomyToklio pushed a commit to pyrex-coin/Pyrex that referenced this pull request Sep 26, 2018

@valiant1x valiant1x referenced this pull request Sep 27, 2018

Merged

RPC/DOS fixes #115

thaerkh added a commit to masari-project/masari that referenced this pull request Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment